Bug 22603 - [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
Summary: [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-02 14:35 PST by Bernd Weber
Modified: 2009-03-11 04:53 PDT (History)
1 user (show)

See Also:


Attachments
Build plugin-related code only for X11 builds (5.46 KB, patch)
2009-03-08 00:16 PST, Jan Alonzo
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Weber 2008-12-02 14:35:53 PST
I tried to cross-compile (buildroot) Webkit GTK on Linux with GTK on top of DirectFB and can see that since "[webkit-changes] [38710] trunk" DumpRenderTree needs X11 when compiling for GTK. This is due to DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp has X11 dependencies:

37: #include <X11/Xlib.h>
197: XEvent* evt = static_cast<XEvent*>(event);
...

Since I'm running DirectFB-GTK the tree doesn't build anymore.
Comment 1 Daniel Laird 2009-01-13 05:34:28 PST
I too have this problem am trying to hack around the building of the offending code.
Comment 2 Jan Alonzo 2009-03-08 00:16:28 PST
Created attachment 28399 [details]
Build plugin-related code only for X11 builds

pangoft2 is not only for X11 target, so add it to PANGO_CFLAGS/LIBS too. Also include stdio.h in PluginPackageGtk as this causes the directfb build to fail.
Comment 3 Holger Freyther 2009-03-11 01:46:13 PDT
Comment on attachment 28399 [details]
Build plugin-related code only for X11 builds

Okay, the pangoft2 change looks a bit strange (not wrong), moving it out of the check of cairoft...
Comment 4 Jan Alonzo 2009-03-11 04:53:07 PDT
Landed in r41579. Thanks!