RESOLVED FIXED 22603
[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore 
https://bugs.webkit.org/show_bug.cgi?id=22603
Summary [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
Bernd Weber
Reported 2008-12-02 14:35:53 PST
I tried to cross-compile (buildroot) Webkit GTK on Linux with GTK on top of DirectFB and can see that since "[webkit-changes] [38710] trunk" DumpRenderTree needs X11 when compiling for GTK. This is due to DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp has X11 dependencies: 37: #include <X11/Xlib.h> 197: XEvent* evt = static_cast<XEvent*>(event); ... Since I'm running DirectFB-GTK the tree doesn't build anymore.
Attachments
Build plugin-related code only for X11 builds (5.46 KB, patch)
2009-03-08 00:16 PST, Jan Alonzo 		zecke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Laird
Comment 1 2009-01-13 05:34:28 PST
I too have this problem am trying to hack around the building of the offending code.
Jan Alonzo
Comment 2 2009-03-08 00:16:28 PST
Created attachment 28399 [details] Build plugin-related code only for X11 builds pangoft2 is not only for X11 target, so add it to PANGO_CFLAGS/LIBS too. Also include stdio.h in PluginPackageGtk as this causes the directfb build to fail.
Holger Freyther
Comment 3 2009-03-11 01:46:13 PDT
Comment on attachment 28399 [details] Build plugin-related code only for X11 builds Okay, the pangoft2 change looks a bit strange (not wrong), moving it out of the check of cairoft...
Jan Alonzo
Comment 4 2009-03-11 04:53:07 PDT
Landed in r41579. Thanks!
Note You need to log in before you can comment on or make changes to this bug.