Bug 225998 – [ Catalina Release JSC] A large number of JSC test appear to be flaky failing

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Robert Jenner]

The following JSC test have started to flaky fail on Catalina Release JSC-Tests:

wasm.yaml/wasm/function-tests/basic-element.js.wasm-eager-jettison
wasm.yaml/wasm/js-api/test_Data.js.wasm-collect-continuously
wasm.yaml/wasm/references/externref_modules.js.wasm-eager
wasm.yaml/wasm/stress/memory-fence.js.wasm-air
wasm.yaml/wasm/stress/mutable-globals.js.wasm-b3
wasm.yaml/wasm/function-tests/basic-element.js.wasm-air
wasm.yaml/wasm/function-tests/stack-trace.js.default-wasm
wasm.yaml/wasm/js-api/test_Data.js.wasm-b3
wasm.yaml/wasm/js-api/test_Data.js.wasm-eager-jettison
wasm.yaml/wasm/references/is_null.js.wasm-b3
wasm.yaml/wasm/stress/js-wasm-call-many-return-types-on-stack-no-args.js.wasm-eager
wasm.yaml/wasm/stress/memory-fence.js.wasm-collect-continuously
wasm.yaml/wasm/stress/too-many-locals.js.default-wasm
wasm.yaml/wasm/function-tests/basic-element.js.wasm-slow-memory
wasm.yaml/wasm/function-tests/stack-trace.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-from-start.js.default-wasm
wasm.yaml/wasm/js-api/test_Data.js.wasm-air
wasm.yaml/wasm/js-api/test_memory.js.wasm-slow-memory
wasm.yaml/wasm/references/externref_table_import.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-store.js.wasm-b3
wasm.yaml/wasm/js-api/test_memory.js.wasm-b3
wasm.yaml/wasm/js-api/test_memory.js.wasm-eager-jettison
wasm.yaml/wasm/lowExecutableMemory/exports-oom.js.default-wasm
wasm.yaml/wasm/js-api/test_memory.js.default-wasm
wasm.yaml/wasm/self-test/test_LowLevelBinary_uint16.js.wasm-b3
wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-collect-continuously
wasm.yaml/wasm/js-api/test_memory.js.wasm-air
wasm.yaml/wasm/references/externref_modules.js.default-wasm
wasm.yaml/wasm/references/func_ref.js.wasm-air
wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-no-tls-context
wasm.yaml/wasm/js-api/test_Data.js.wasm-no-tls-context
wasm.yaml/wasm/references/func_ref.js.default-wasm
stress/put-by-val-slow-put-array-storage.js.dfg-eager-no-cjit-validate
stress/arrowfunction-lexical-bind-arguments-non-strict-1.js.dfg-eager
stress/arrowfunction-lexical-bind-superproperty.js.dfg-eager

HISTORY:
https://build.webkit.org/#/builders/Apple-Catalina-Release-JSC-Tests?numbuilds=50


These failures started occurring at this test run:
https://build.webkit.org/#/builders/4/builds/1998

My guess is that either r277727, or r277725 caused this, as they both appear to have made changes to things with JSC.

[Robert Jenner]

Created attachment 429124 [details]
Crashlog from Catalina JSC-tests bot

Attaching crashlogs collected from the Catalina-JSC-Tests bot.

[Radar WebKit Bug Importer]

<rdar://problem/78235001>

[Mark Lam]

These failures are reported from a Release bot.  r277727 is only enabled on a Debug build.  So, this cannot be r277727.

[Saam Barati]

I'm looking

[Saam Barati]

I have a fix

[Saam Barati]

Created attachment 429219 [details]
patch

[Yusuke Suzuki]

Comment on attachment 429219 [details]
patch

r=me

[Saam Barati]

Created attachment 429240 [details]
patch for landing

[Saam Barati]

Created attachment 429251 [details]
patch for landing

[Saam Barati]

Created attachment 429265 [details]
patch for landing

[EWS]

Committed r277850 (237992@main): <https://commits.webkit.org/237992@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429265 [details].

[Fujii Hironori]

r277850 made WinCairo (Debug) crashing.
Filed: Bug 226110 – ASSERTION FAILED: !isCompilationThread() in ctiStub of JITThunks.cpp since r277850