Bug 225998 - [ Catalina Release JSC] A large number of JSC test appear to be flaky failing
Summary: [ Catalina Release JSC] A large number of JSC test appear to be flaky failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 226110
  Show dependency tree / graph
 
Reported: 2021-05-19 17:57 PDT by Robert Jenner
Modified: 2021-05-21 13:51 PDT (History)
10 users (show)

See Also:

Attachments
Crashlog from Catalina JSC-tests bot (94.19 KB, application/zip)
2021-05-19 17:58 PDT, Robert Jenner 		no flags Details
patch (9.55 KB, patch)
2021-05-20 14:08 PDT, Saam Barati 		ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (10.05 KB, patch)
2021-05-20 16:34 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (11.34 KB, patch)
2021-05-20 17:52 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (11.41 KB, patch)
2021-05-20 22:50 PDT, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-05-19 17:57:20 PDT 
The following JSC test have started to flaky fail on Catalina Release JSC-Tests:

wasm.yaml/wasm/function-tests/basic-element.js.wasm-eager-jettison
wasm.yaml/wasm/js-api/test_Data.js.wasm-collect-continuously
wasm.yaml/wasm/references/externref_modules.js.wasm-eager
wasm.yaml/wasm/stress/memory-fence.js.wasm-air
wasm.yaml/wasm/stress/mutable-globals.js.wasm-b3
wasm.yaml/wasm/function-tests/basic-element.js.wasm-air
wasm.yaml/wasm/function-tests/stack-trace.js.default-wasm
wasm.yaml/wasm/js-api/test_Data.js.wasm-b3
wasm.yaml/wasm/js-api/test_Data.js.wasm-eager-jettison
wasm.yaml/wasm/references/is_null.js.wasm-b3
wasm.yaml/wasm/stress/js-wasm-call-many-return-types-on-stack-no-args.js.wasm-eager
wasm.yaml/wasm/stress/memory-fence.js.wasm-collect-continuously
wasm.yaml/wasm/stress/too-many-locals.js.default-wasm
wasm.yaml/wasm/function-tests/basic-element.js.wasm-slow-memory
wasm.yaml/wasm/function-tests/stack-trace.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-from-start.js.default-wasm
wasm.yaml/wasm/js-api/test_Data.js.wasm-air
wasm.yaml/wasm/js-api/test_memory.js.wasm-slow-memory
wasm.yaml/wasm/references/externref_table_import.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-store.js.wasm-b3
wasm.yaml/wasm/js-api/test_memory.js.wasm-b3
wasm.yaml/wasm/js-api/test_memory.js.wasm-eager-jettison
wasm.yaml/wasm/lowExecutableMemory/exports-oom.js.default-wasm
wasm.yaml/wasm/js-api/test_memory.js.default-wasm
wasm.yaml/wasm/self-test/test_LowLevelBinary_uint16.js.wasm-b3
wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-collect-continuously
wasm.yaml/wasm/js-api/test_memory.js.wasm-air
wasm.yaml/wasm/references/externref_modules.js.default-wasm
wasm.yaml/wasm/references/func_ref.js.wasm-air
wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-no-tls-context
wasm.yaml/wasm/js-api/test_Data.js.wasm-no-tls-context
wasm.yaml/wasm/references/func_ref.js.default-wasm
stress/put-by-val-slow-put-array-storage.js.dfg-eager-no-cjit-validate
stress/arrowfunction-lexical-bind-arguments-non-strict-1.js.dfg-eager
stress/arrowfunction-lexical-bind-superproperty.js.dfg-eager

HISTORY:
https://build.webkit.org/#/builders/Apple-Catalina-Release-JSC-Tests?numbuilds=50


These failures started occurring at this test run:
https://build.webkit.org/#/builders/4/builds/1998

My guess is that either r277727, or r277725 caused this, as they both appear to have made changes to things with JSC.
Comment 1 Robert Jenner 2021-05-19 17:58:26 PDT 
Created attachment 429124 [details]
Crashlog from Catalina JSC-tests bot

Attaching crashlogs collected from the Catalina-JSC-Tests bot.
Comment 2 Radar WebKit Bug Importer 2021-05-19 18:14:42 PDT 
<rdar://problem/78235001>
Comment 3 Mark Lam 2021-05-20 08:13:32 PDT 
These failures are reported from a Release bot.  r277727 is only enabled on a Debug build.  So, this cannot be r277727.
Comment 4 Saam Barati 2021-05-20 12:16:45 PDT 
I'm looking
Comment 5 Saam Barati 2021-05-20 13:30:16 PDT 
I have a fix
Comment 6 Saam Barati 2021-05-20 14:08:28 PDT 
Created attachment 429219 [details]
patch
Comment 7 Yusuke Suzuki 2021-05-20 14:10:34 PDT 
Comment on attachment 429219 [details]
patch

r=me
Comment 8 Saam Barati 2021-05-20 16:34:33 PDT 
Created attachment 429240 [details]
patch for landing
Comment 9 Saam Barati 2021-05-20 17:52:56 PDT 
Created attachment 429251 [details]
patch for landing
Comment 10 Saam Barati 2021-05-20 22:50:24 PDT 
Created attachment 429265 [details]
patch for landing
Comment 11 EWS 2021-05-20 23:35:14 PDT 
Committed r277850 (237992@main): <https://commits.webkit.org/237992@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429265 [details].
Comment 12 Fujii Hironori 2021-05-21 13:51:42 PDT 
r277850 made WinCairo (Debug) crashing.
Filed: Bug 226110 – ASSERTION FAILED: !isCompilationThread() in ctiStub of JITThunks.cpp since r277850