RESOLVED FIXED 225988
Introduce SQLiteStatement::columnBlobView() 
https://bugs.webkit.org/show_bug.cgi?id=225988
Summary Introduce SQLiteStatement::columnBlobView()
Chris Dumez
Reported 2021-05-19 15:35:19 PDT
Introduce SQLiteStatement::columnBlobView() to get a "view" to the blob instead of copying the data. This is more efficient for call sites that do not need to hold on the the Blob data.
Attachments
Patch (15.62 KB, patch)
2021-05-19 15:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-19 15:36:30 PDT
Created attachment 429103 [details] Patch
Alex Christensen
Comment 2 2021-05-19 16:39:17 PDT
Comment on attachment 429103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429103&action=review > Source/WebCore/platform/sql/SQLiteStatement.h:75 > + class BlobView { We really need to start using std::span for things like this.
Chris Dumez
Comment 3 2021-05-19 16:44:43 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 429103 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429103&action=review > > > Source/WebCore/platform/sql/SQLiteStatement.h:75 > > + class BlobView { > > We really need to start using std::span for things like this. Yes, someone just needs to import it :P
Alex Christensen
Comment 4 2021-05-19 16:52:46 PDT
I volunteer myself.
Chris Dumez
Comment 5 2021-05-19 17:11:06 PDT
(In reply to Alex Christensen from comment #4) > I volunteer myself. 👍
EWS
Comment 6 2021-05-19 17:51:43 PDT
Committed r277768 (237931@main): <https://commits.webkit.org/237931@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429103 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-19 17:52:20 PDT
<rdar://problem/78234144>
Note You need to log in before you can comment on or make changes to this bug.