Introduce SQLiteStatement::columnBlobView()

[Chris Dumez]

Introduce SQLiteStatement::columnBlobView() to get a "view" to the blob instead of copying the data. This is more efficient for call sites that do not need to hold on the the Blob data.

[Chris Dumez]

Created attachment 429103 [details]
Patch

[Alex Christensen]

Comment on attachment 429103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429103&action=review

> Source/WebCore/platform/sql/SQLiteStatement.h:75
> +    class BlobView {

We really need to start using std::span for things like this.

[Chris Dumez]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 429103 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429103&action=review
> 
> > Source/WebCore/platform/sql/SQLiteStatement.h:75
> > +    class BlobView {
> 
> We really need to start using std::span for things like this.

Yes, someone just needs to import it :P

[Alex Christensen]

I volunteer myself.

[Chris Dumez]

(In reply to Alex Christensen from comment #4)
> I volunteer myself.

👍

[EWS]

Committed r277768 (237931@main): <https://commits.webkit.org/237931@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429103 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78234144>