Bug 225974 - [iOS][FCR] <select multiple> picker should collapse sections when tapping anywhere on a group header
Summary: [iOS][FCR] <select multiple> picker should collapse sections when tapping any...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-19 10:13 PDT by Aditya Keerthi
Modified: 2021-05-19 12:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.41 KB, patch)
2021-05-19 10:16 PDT, Aditya Keerthi 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (11.51 KB, patch)
2021-05-19 10:45 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-05-19 10:13:45 PDT 
...
Comment 1 Aditya Keerthi 2021-05-19 10:14:03 PDT 
<rdar://problem/77930033>
Comment 2 Aditya Keerthi 2021-05-19 10:16:20 PDT 
Created attachment 429062 [details]
Patch
Comment 3 Wenson Hsieh 2021-05-19 10:26:33 PDT 
Comment on attachment 429062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429062&action=review

r=mews

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:753
> +@protocol WKSelectPickerGroupHeaderViewDelegate <NSObject>
> +- (void)didTapSelectPickerGroupHeaderView:(WKSelectPickerGroupHeaderView *)headerView;
> +@end

Nit - since this is all internal to `WKSelectPickerGroupHeaderView` and `WKSelectPickerTableViewController` anyways, can we just directly pass in the `WKSelectPickerTableViewController` and remove this protocol?
Comment 4 Aditya Keerthi 2021-05-19 10:45:18 PDT 
Created attachment 429071 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-05-19 10:45:53 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 429062 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429062&action=review
> 
> r=mews

Thanks for the review!
 
> > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:753
> > +@protocol WKSelectPickerGroupHeaderViewDelegate <NSObject>
> > +- (void)didTapSelectPickerGroupHeaderView:(WKSelectPickerGroupHeaderView *)headerView;
> > +@end
> 
> Nit - since this is all internal to `WKSelectPickerGroupHeaderView` and
> `WKSelectPickerTableViewController` anyways, can we just directly pass in
> the `WKSelectPickerTableViewController` and remove this protocol?

I've removed the protocol.
Comment 6 EWS 2021-05-19 12:32:17 PDT 
Committed r277743 (237915@main): <https://commits.webkit.org/237915@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429071 [details].