Bug 225974 – [iOS][FCR] <select multiple> picker should collapse sections when tapping anywhere on a group header

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

...

[Aditya Keerthi]

<rdar://problem/77930033>

[Aditya Keerthi]

Created attachment 429062 [details]
Patch

[Wenson Hsieh]

Comment on attachment 429062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429062&action=review

r=mews

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:753
> +@protocol WKSelectPickerGroupHeaderViewDelegate <NSObject>
> +- (void)didTapSelectPickerGroupHeaderView:(WKSelectPickerGroupHeaderView *)headerView;
> +@end

Nit - since this is all internal to `WKSelectPickerGroupHeaderView` and `WKSelectPickerTableViewController` anyways, can we just directly pass in the `WKSelectPickerTableViewController` and remove this protocol?

[Aditya Keerthi]

Created attachment 429071 [details]
Patch for landing

[Aditya Keerthi]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 429062 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429062&action=review
> 
> r=mews

Thanks for the review!
 
> > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:753
> > +@protocol WKSelectPickerGroupHeaderViewDelegate <NSObject>
> > +- (void)didTapSelectPickerGroupHeaderView:(WKSelectPickerGroupHeaderView *)headerView;
> > +@end
> 
> Nit - since this is all internal to `WKSelectPickerGroupHeaderView` and
> `WKSelectPickerTableViewController` anyways, can we just directly pass in
> the `WKSelectPickerTableViewController` and remove this protocol?

I've removed the protocol.

[EWS]

Committed r277743 (237915@main): <https://commits.webkit.org/237915@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429071 [details].