Bug 225965 - git-webkit should have a command to diff against HEAD / main
Summary: git-webkit should have a command to diff against HEAD / main
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency treegraph
 
Reported: 2021-05-19 02:33 PDT by Ryosuke Niwa
Modified: 2022-08-09 08:31 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-05-19 02:33:29 PDT
There should be a command like `git-webkit diff` which diffs against main to match `svn diff`.
Comment 1 Alexey Proskuryakov 2021-05-19 07:33:18 PDT
Can you clarify what you’d like it to do? Just git diff HEAD?
Comment 2 Jonathan Bedard 2021-05-19 08:34:17 PDT
I don't know exactly what Ryosuke had in mind for this bug, but in my opinion, this basically translates to "show me the set of changes I have locally that do not appear on the remote". This is important for style checking and for generating a pretty-diff, which is a function that is currently tied to bugzilla's patch review.
Comment 3 Kocsen Chung 2021-05-19 10:53:45 PDT
This seems akin to a `git diff (--cached) (HEAD|main)`. Unless we want `git-webkit` to do anything different like the pretty-patch aforementioned, then I don't think we should have `git-webkit` do this. 
My intent is to avoid `git-webkit` to repeat every single git command if it doesn't have additional logic or benefit to the user.
Comment 4 Radar WebKit Bug Importer 2021-05-26 02:34:17 PDT
<rdar://problem/78502801>
Comment 5 Ryosuke Niwa 2021-09-28 13:21:48 PDT
(In reply to Kocsen Chung from comment #3)
> This seems akin to a `git diff (--cached) (HEAD|main)`. Unless we want
> `git-webkit` to do anything different like the pretty-patch aforementioned,
> then I don't think we should have `git-webkit` do this. 
> My intent is to avoid `git-webkit` to repeat every single git command if it
> doesn't have additional logic or benefit to the user.

The additional benefit is that you don't have to remember to type cryptic options like --cached / --index or HEAD/main.

After 10 years of using Git, I can never bother to remember all these random names and commands because they don't make slightest of logical sense.