WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
225965
git-webkit should have a command to diff against HEAD / main
https://bugs.webkit.org/show_bug.cgi?id=225965
Summary
git-webkit should have a command to diff against HEAD / main
Ryosuke Niwa
Reported
2021-05-19 02:33:29 PDT
There should be a command like `git-webkit diff` which diffs against main to match `svn diff`.
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2021-05-19 07:33:18 PDT
Can you clarify what you’d like it to do? Just git diff HEAD?
Jonathan Bedard
Comment 2
2021-05-19 08:34:17 PDT
I don't know exactly what Ryosuke had in mind for this bug, but in my opinion, this basically translates to "show me the set of changes I have locally that do not appear on the remote". This is important for style checking and for generating a pretty-diff, which is a function that is currently tied to bugzilla's patch review.
Kocsen Chung
Comment 3
2021-05-19 10:53:45 PDT
This seems akin to a `git diff (--cached) (HEAD|main)`. Unless we want `git-webkit` to do anything different like the pretty-patch aforementioned, then I don't think we should have `git-webkit` do this. My intent is to avoid `git-webkit` to repeat every single git command if it doesn't have additional logic or benefit to the user.
Radar WebKit Bug Importer
Comment 4
2021-05-26 02:34:17 PDT
<
rdar://problem/78502801
>
Ryosuke Niwa
Comment 5
2021-09-28 13:21:48 PDT
(In reply to Kocsen Chung from
comment #3
)
> This seems akin to a `git diff (--cached) (HEAD|main)`. Unless we want > `git-webkit` to do anything different like the pretty-patch aforementioned, > then I don't think we should have `git-webkit` do this. > My intent is to avoid `git-webkit` to repeat every single git command if it > doesn't have additional logic or benefit to the user.
The additional benefit is that you don't have to remember to type cryptic options like --cached / --index or HEAD/main. After 10 years of using Git, I can never bother to remember all these random names and commands because they don't make slightest of logical sense.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug