Bug 22596 - Some elements don't report AXBlockQuoteLevel
Summary: Some elements don't report AXBlockQuoteLevel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-02 12:08 PST by chris fleizach
Modified: 2009-01-12 23:40 PST (History)
0 users

See Also:


Attachments
Patch to return blockquote level for all elements (6.22 KB, patch)
2008-12-02 12:38 PST, chris fleizach
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2008-12-02 12:08:12 PST
Elements that are not render objects are not returning their block quote level
Comment 1 chris fleizach 2008-12-02 12:38:35 PST
Created attachment 25678 [details]
Patch to return blockquote level for all elements
Comment 2 John Sullivan 2008-12-02 13:19:43 PST
Comment on attachment 25678 [details]
Patch to return blockquote level for all elements


> +        if ([attributeName isEqualToString: NSAccessibilityBlockQuoteLevelAttribute])

Our style is to not have a space between colons and parameters in ObjC method calls. I see that the current code here is inconsistent, but it would be good to eliminate this space in new code (at least).

> +            return [m_object->parentObjectUnignored()->wrapper() accessibilityAttributeValue:NSAccessibilityBlockQuoteLevelAttribute];        
>      }

r=me, assuming you are sure that m_object and m_object->parentObjectUnignored() are guaranteed to be non-0.
Comment 3 Mark Rowe (bdash) 2009-01-12 23:40:25 PST
This was landed in <http://trac.webkit.org/changeset/38915>.