Bug 225957 - allowsContentJavaScript API not applied from defaultWebpagePreferences
Summary: allowsContentJavaScript API not applied from defaultWebpagePreferences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-18 19:16 PDT by Tim Horton
Modified: 2021-05-19 10:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.32 KB, patch)
2021-05-18 19:16 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-05-18 19:16:10 PDT 
allowsContentJavaScript API not applied from defaultWebpagePreferences
Comment 1 Tim Horton 2021-05-18 19:16:28 PDT 
Created attachment 429022 [details]
Patch
Comment 2 Tim Horton 2021-05-18 19:16:40 PDT 
I checked, this is the only one missing.
Comment 3 EWS 2021-05-18 20:11:03 PDT 
Committed r277713 (237892@main): <https://commits.webkit.org/237892@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429022 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-18 20:12:17 PDT 
<rdar://problem/78186580>
Comment 5 Darin Adler 2021-05-19 10:34:41 PDT 
Comment on attachment 429022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429022&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:443
> +    RetainPtr<WKWebpagePreferences> preferences = adoptNS([[WKWebpagePreferences alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:446
> +    RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:449
> +    RetainPtr<TestWKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);

auto