Bug 225940 - Link Baseline JIT code off the main thread
Summary: Link Baseline JIT code off the main thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-18 15:34 PDT by Saam Barati
Modified: 2021-05-19 09:35 PDT (History)
7 users (show)

See Also:

Attachments
patch (12.19 KB, patch)
2021-05-18 16:38 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (12.19 KB, patch)
2021-05-18 16:39 PDT, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (12.23 KB, patch)
2021-05-18 16:55 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-05-18 15:34:39 PDT 
...
Comment 1 Saam Barati 2021-05-18 16:38:20 PDT 
Created attachment 428996 [details]
patch
Comment 2 Saam Barati 2021-05-18 16:39:31 PDT 
Created attachment 428998 [details]
patch
Comment 3 Yusuke Suzuki 2021-05-18 16:42:27 PDT 
Comment on attachment 428998 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428998&action=review

r=me

> Source/JavaScriptCore/jit/JIT.cpp:1008
> +    if (!m_jitCode)

Let's add assertion that ensures this is not compilation thread.
Comment 4 Saam Barati 2021-05-18 16:43:16 PDT 
Comment on attachment 428998 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428998&action=review

>> Source/JavaScriptCore/jit/JIT.cpp:1008
>> +    if (!m_jitCode)
> 
> Let's add assertion that ensures this is not compilation thread.

sounds good
Comment 5 Saam Barati 2021-05-18 16:55:18 PDT 
Created attachment 429000 [details]
patch for landing
Comment 6 EWS 2021-05-19 09:35:01 PDT 
Committed r277725 (237902@main): <https://commits.webkit.org/237902@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429000 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-19 09:35:17 PDT 
<rdar://problem/78209510>