Bug 22594 – Fetching inline style with foo.style.webkitTransition returns nothing

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

If an element has inline -webkit-transform style, reading back foo.style.webkitTransform returns nothing.

[Simon Fraser (smfr)]

Transition, not transform.

[Simon Fraser (smfr)]

Created attachment 25683 [details]
Testcase

[Simon Fraser (smfr)]

Patch is something like this:

diff --git a/WebCore/css/CSSMutableStyleDeclaration.cpp b/WebCore/css/CSSMutableStyleDeclaration.cpp
index ca0295a..8651761 100644
--- a/WebCore/css/CSSMutableStyleDeclaration.cpp
+++ b/WebCore/css/CSSMutableStyleDeclaration.cpp
@@ -201,6 +201,17 @@ String CSSMutableStyleDeclaration::getPropertyValue(int propertyID) const
                                        CSSPropertyWebkitMaskOrigin };
             return getLayeredShorthandValue(properties, 6);
         }
+        case CSSPropertyWebkitTransition: {
+            const int properties[4] = { CSSPropertyWebkitTransitionProperty, CSSPropertyWebkitTransitionDuration,
+                                        CSSPropertyWebkitTransitionTimingFunction, CSSPropertyWebkitTransitionDelay };
+            return getShorthandValue(properties, 4);
+        }
+        case CSSPropertyWebkitTransformOrigin: {
+            // FIXME: Is this correct? The code in cssparser.cpp is confusing
+            const int properties[2] = { CSSPropertyWebkitTransformOriginX,
+                                        CSSPropertyWebkitTransformOriginY };
+            return getLayeredShorthandValue(properties, 2);
+        }
 #if ENABLE(SVG)
         case CSSPropertyMarker: {
             RefPtr<CSSValue> value = getPropertyCSSValue(CSSPropertyMarkerStart);

but that isn't quite right. In the testcase, it prints "style: left 1s ease-in initial" when the delay is not in the shorthand. It should not print the "initial". Compare with "border".

[Simon Fraser (smfr)]

Also, 'all' doesn't show in the output. 'all' is broken in computed style, too.

[Simon Fraser (smfr)]

Taking.

[Simon Fraser (smfr)]

Created attachment 25836 [details]
Patch, testcase, changelog

Comment on attachment 25836 [details]
Patch, testcase, changelog

r=me, but feel free to use standard indentation in the change log :)

[Simon Fraser (smfr)]

Fixed the changelog.
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/css/transform-inline-style-expected.txt
	A	LayoutTests/fast/css/transform-inline-style.html
	M	WebCore/ChangeLog
	M	WebCore/css/CSSMutableStyleDeclaration.cpp
	M	WebCore/css/CSSParser.cpp
	M	WebCore/css/CSSStyleSelector.cpp
Committed r39090