Bug 225934 - Clean up git svn mapping when git pull
Summary: Clean up git svn mapping when git pull
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhifei Fang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-18 13:24 PDT by Zhifei Fang
Modified: 2021-05-18 14:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2021-05-18 13:25 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2021-05-18 13:24:53 PDT 
Clean up git svn mapping when git pull
Comment 1 Zhifei Fang 2021-05-18 13:25:04 PDT 
Created attachment 428974 [details]
Patch
Comment 2 Zhifei Fang 2021-05-18 13:28:05 PDT 
There will be a time different when publish our commit to GitHub and our svn server. git svn will build a fake commit when it can not find the GitHub commit but find a svn revision, it won't include the identifier and it won't have any real commits point to it after the git pull, we should rebuild the svn map to make sure the revision point to the GitHub commit.
Comment 3 Ryosuke Niwa 2021-05-18 13:36:26 PDT 
Comment on attachment 428974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428974&action=review

> Websites/perf.webkit.org/tools/sync-commits.py:291
> +            subprocess.check_call(['rm', '-rf', os.path.join(self._git_checkout, '.git/svn')])

Yikes.
Comment 4 EWS 2021-05-18 14:25:52 PDT 
Committed r277679 (237880@main): <https://commits.webkit.org/237880@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428974 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-18 14:26:19 PDT 
<rdar://problem/78173466>