Bug 225933 - [webkitpy] Forward booted simulators to children processes
Summary: [webkitpy] Forward booted simulators to children processes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on: 225954
Blocks:
  Show dependency treegraph
 
Reported: 2021-05-18 13:16 PDT by Jonathan Bedard
Modified: 2021-05-20 07:45 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.04 KB, patch)
2021-05-18 13:29 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
[fast-cq] Patch for landing (3.03 KB, patch)
2021-05-18 13:41 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2021-05-19 08:00 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (3.37 KB, patch)
2021-05-20 07:20 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-05-18 13:16:10 PDT
Booted simulators need to be forwarded to children processes for iOS Simulator API tests to work.
Comment 1 Radar WebKit Bug Importer 2021-05-18 13:16:25 PDT
<rdar://problem/78169900>
Comment 2 Jonathan Bedard 2021-05-18 13:29:37 PDT
Created attachment 428975 [details]
Patch
Comment 3 Aakash Jain 2021-05-18 13:33:45 PDT
Comment on attachment 428975 [details]
Patch

rs=me
Comment 4 Jonathan Bedard 2021-05-18 13:41:59 PDT
Created attachment 428976 [details]
[fast-cq] Patch for landing
Comment 5 EWS 2021-05-18 13:58:40 PDT
Committed r277675 (237876@main): <https://commits.webkit.org/237876@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428976 [details].
Comment 6 Tim Horton 2021-05-18 18:40:48 PDT
I think this broke API testing on macOS.
Comment 7 WebKit Commit Bot 2021-05-18 18:46:30 PDT
Re-opened since this is blocked by bug 225954
Comment 8 Alexey Proskuryakov 2021-05-18 18:47:33 PDT
Reverting - better to have API tests work on macOS at least.
Comment 9 Jonathan Bedard 2021-05-19 08:00:56 PDT
Created attachment 429049 [details]
Patch
Comment 10 Aakash Jain 2021-05-20 07:09:31 PDT
rs=me
Comment 11 Jonathan Bedard 2021-05-20 07:20:30 PDT
Created attachment 429169 [details]
Patch for landing
Comment 12 EWS 2021-05-20 07:45:37 PDT
Committed r277782 (237943@main): <https://commits.webkit.org/237943@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429169 [details].