Bug 225911 - Commits updater should ignore null revision identifier
Summary: Commits updater should ignore null revision identifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhifei Fang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-18 02:05 PDT by Zhifei Fang
Modified: 2021-05-18 12:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2021-05-18 02:06 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Patch (12.87 KB, patch)
2021-05-18 12:05 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2021-05-18 02:05:41 PDT 
Commits updater should ignore null revision identifier
Comment 1 Zhifei Fang 2021-05-18 02:06:05 PDT 
Created attachment 428920 [details]
Patch
Comment 2 Zhifei Fang 2021-05-18 02:08:05 PDT 
We should ignore 

{
  ...
  revisionIdentifier: null
}

As the sync_commit.py will submit such format when sync with normal git repo
Comment 3 Ryosuke Niwa 2021-05-18 02:31:06 PDT 
Comment on attachment 428920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428920&action=review

> Websites/perf.webkit.org/public/include/commit-updater.php:172
> -        if (array_key_exists('revisionIdentifier', $commit_info))
> +        if (array_key_exists('revisionIdentifier', $commit_info) && isset($commit_info['revisionIdentifier']))

Can we add a test for this? This seems like a pretty serious oversight in our testing.
Comment 4 Zhifei Fang 2021-05-18 12:05:08 PDT 
Created attachment 428960 [details]
Patch
Comment 5 Ryosuke Niwa 2021-05-18 12:36:11 PDT 
Comment on attachment 428960 [details]
Patch

Great. Thanks for the tests!
Comment 6 EWS 2021-05-18 12:56:11 PDT 
Committed r277671 (237872@main): <https://commits.webkit.org/237872@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428960 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-18 12:57:17 PDT 
<rdar://problem/78168984>