RESOLVED FIXED 225908
Use RefPtr for local ref counted objects of FrameSelection::setSelectionWithoutUpdatingAppearance 
https://bugs.webkit.org/show_bug.cgi?id=225908
Summary Use RefPtr for local ref counted objects of FrameSelection::setSelectionWitho...
Frédéric Wang (:fredw)
Reported 2021-05-17 23:10:12 PDT
.
Attachments
Patch (4.59 KB, patch)
2021-05-17 23:11 PDT, Frédéric Wang (:fredw) 		rniwa: review+
DetailsFormatted DiffDiff
Patch for landing (4.58 KB, patch)
2021-05-18 02:34 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-05-17 23:10:26 PDT
<rdar://problem/78140308>
Frédéric Wang (:fredw)
Comment 2 2021-05-17 23:11:27 PDT
Created attachment 428915 [details] Patch
Ryosuke Niwa
Comment 3 2021-05-18 01:49:21 PDT
Comment on attachment 428915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review > Source/WebCore/editing/FrameSelection.cpp:1944 > - ContainerNode* ownerElementParent = ownerElement->parentNode(); > + RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode(); Use makeRefPtr?
Ryosuke Niwa
Comment 4 2021-05-18 01:49:37 PDT
I don't think this needs to be in the security component unless there is an actual security bug we're fixing.
Frédéric Wang (:fredw)
Comment 5 2021-05-18 01:54:07 PDT
Comment on attachment 428915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review >> Source/WebCore/editing/FrameSelection.cpp:1944 >> + RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode(); > > Use makeRefPtr? This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case?
Frédéric Wang (:fredw)
Comment 6 2021-05-18 01:55:34 PDT
(In reply to Ryosuke Niwa from comment #4) > I don't think this needs to be in the security component unless there is an > actual security bug we're fixing. Yeah, reading the code, I don't think any of this use is "dangerous".
Ryosuke Niwa
Comment 7 2021-05-18 02:03:51 PDT
Comment on attachment 428915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review >>> Source/WebCore/editing/FrameSelection.cpp:1944 >>> + RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode(); >> >> Use makeRefPtr? > > This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case? I'm confused. Given Node::parentNode() returns ContainerNode, calling makeRefPtr will surely make it RefPtr<ContainerNode>?
Frédéric Wang (:fredw)
Comment 8 2021-05-18 02:31:44 PDT
Comment on attachment 428915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review >>>> Source/WebCore/editing/FrameSelection.cpp:1944 >>>> + RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode(); >>> >>> Use makeRefPtr? >> >> This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case? > > I'm confused. Given Node::parentNode() returns ContainerNode, calling makeRefPtr will surely make it RefPtr<ContainerNode>? OK, I stand corrected. I had build errors when I tried yesterday, but probably that was something else. Will update the patch and land it.
Frédéric Wang (:fredw)
Comment 9 2021-05-18 02:34:32 PDT
Created attachment 428923 [details] Patch for landing
EWS
Comment 10 2021-05-18 03:01:34 PDT
Committed r277647 (237853@main): <https://commits.webkit.org/237853@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428923 [details].
Note You need to log in before you can comment on or make changes to this bug.