.
<rdar://problem/78140308>
Created attachment 428915 [details] Patch
Comment on attachment 428915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review > Source/WebCore/editing/FrameSelection.cpp:1944 > - ContainerNode* ownerElementParent = ownerElement->parentNode(); > + RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode(); Use makeRefPtr?
I don't think this needs to be in the security component unless there is an actual security bug we're fixing.
Comment on attachment 428915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review >> Source/WebCore/editing/FrameSelection.cpp:1944 >> + RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode(); > > Use makeRefPtr? This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case?
(In reply to Ryosuke Niwa from comment #4) > I don't think this needs to be in the security component unless there is an > actual security bug we're fixing. Yeah, reading the code, I don't think any of this use is "dangerous".
Comment on attachment 428915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review >>> Source/WebCore/editing/FrameSelection.cpp:1944 >>> + RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode(); >> >> Use makeRefPtr? > > This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case? I'm confused. Given Node::parentNode() returns ContainerNode, calling makeRefPtr will surely make it RefPtr<ContainerNode>?
Comment on attachment 428915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428915&action=review >>>> Source/WebCore/editing/FrameSelection.cpp:1944 >>>> + RefPtr<ContainerNode> ownerElementParent = ownerElement->parentNode(); >>> >>> Use makeRefPtr? >> >> This needs to be cast to RefPtr<ContainerNode>. Not sure how we do that in our code... or maybe you mean adding makeRefPtr in any case? > > I'm confused. Given Node::parentNode() returns ContainerNode, calling makeRefPtr will surely make it RefPtr<ContainerNode>? OK, I stand corrected. I had build errors when I tried yesterday, but probably that was something else. Will update the patch and land it.
Created attachment 428923 [details] Patch for landing
Committed r277647 (237853@main): <https://commits.webkit.org/237853@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428923 [details].