Bug 225906 - Enabling IPC testing API should prevent WebContent process from getting terminated in more cases
Summary: Enabling IPC testing API should prevent WebContent process from getting termi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-17 21:13 PDT by Ryosuke Niwa
Modified: 2021-05-18 14:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.79 KB, patch)
2021-05-17 21:17 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-05-17 21:13:13 PDT 
There are a few more cases in which WebContent process were hitting debug assertions and/or getting killed by GPU Process.
Avoid that.
Comment 1 Ryosuke Niwa 2021-05-17 21:17:45 PDT 
Created attachment 428911 [details]
Patch
Comment 2 Ryosuke Niwa 2021-05-17 22:15:18 PDT 
Comment on attachment 428911 [details]
Patch

Clearing flags on attachment: 428911

Committed r277641 (237847@main): <https://commits.webkit.org/237847@main>
Comment 3 Ryosuke Niwa 2021-05-17 22:15:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2021-05-17 22:16:20 PDT 
<rdar://problem/78138794>
Comment 5 Jonathan Bedard 2021-05-18 13:35:38 PDT 
This broke a webkitpy test about WebKit's IPC messages:
https://results.webkit.org/?suite=webkitpy-tests&test=webkit.messages_unittest.GeneratedFileContentsTest.test_receiver
Comment 6 Ryosuke Niwa 2021-05-18 13:38:58 PDT 
(In reply to Jonathan Bedard from comment #5)
> This broke a webkitpy test about WebKit's IPC messages:
> https://results.webkit.org/?suite=webkitpy-tests&test=webkit.
> messages_unittest.GeneratedFileContentsTest.test_receiver

WTF... why do we have tests in webkitpy?
Comment 7 Ryosuke Niwa 2021-05-18 14:04:34 PDT 
Committed r277677 (237878@main): <https://commits.webkit.org/237878@main>