Bug 225898 – [lint-test-expectations] Change shebang to Python 3

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

lint-test-expectations should be invoked with Python 3.

[Radar WebKit Bug Importer]

<rdar://problem/78130334>

[Jonathan Bedard]

Created attachment 428898 [details]
Patch

[Aakash Jain]

Comment on attachment 428898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428898&action=review

> Tools/Scripts/webkitpy/common/version_check.py:-32
> -if sys.version < '2.7' or sys.version >= '2.8':

Are we dropping support for 2.7? If so, it would a good idea to have exit early here if this code is run with python 2.7 (or atleast print a warning that python 2.7 is not supported anymore).

[Jonathan Bedard]

(In reply to Aakash Jain from comment #3)
> Comment on attachment 428898 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428898&action=review
> 
> > Tools/Scripts/webkitpy/common/version_check.py:-32
> > -if sys.version < '2.7' or sys.version >= '2.8':
> 
> Are we dropping support for 2.7? If so, it would a good idea to have exit
> early here if this code is run with python 2.7 (or atleast print a warning
> that python 2.7 is not supported anymore).

I guess we can keep the "less than 2.7" check, the trouble is that this check applies to more than just this script. I object to enshrining version checks like this anyways, we support some versions of Python 3 right now, but even that depends on the script and platform (ie, windows supports Python 3.8+, Mac supports only supports up to Python 3.7)

[Jonathan Bedard]

Created attachment 428946 [details]
Patch

[EWS]

Committed r277668 (237870@main): <https://commits.webkit.org/237870@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428946 [details].