Bug 225897 - _WKWebAuthenticationPanelDelegate registration and assertion SPI throws an exception without an LAContext
Summary: _WKWebAuthenticationPanelDelegate registration and assertion SPI throws an ex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Garrett Davidson
URL:
Keywords: InRadar
Depends on:
Blocks: 231814
  Show dependency treegraph
 
Reported: 2021-05-17 16:43 PDT by Garrett Davidson
Modified: 2021-10-15 10:35 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.73 KB, patch)
2021-05-17 17:08 PDT, Garrett Davidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Garrett Davidson 2021-05-17 16:43:10 PDT
The fix for 225218 was incomplete. Now instead of dropping the request entirely, WebKit tries to proceed and attempts to stick the nil contexts in NSDictionaries, throwing exceptions.
Comment 1 Radar WebKit Bug Importer 2021-05-17 16:47:08 PDT
<rdar://problem/78128655>
Comment 2 Garrett Davidson 2021-05-17 17:08:38 PDT
Created attachment 428896 [details]
Patch
Comment 3 EWS 2021-05-18 09:49:10 PDT
garrett_davidson@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 428896 [details] from commit queue.
Comment 4 EWS 2021-05-18 10:04:41 PDT
Committed r277658 (237863@main): <https://commits.webkit.org/237863@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428896 [details].