Bug 225893 - Adopt SecTrustGetCertificateAtIndex replacement where available
Summary: Adopt SecTrustGetCertificateAtIndex replacement where available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-17 16:12 PDT by Alex Christensen
Modified: 2021-06-07 19:25 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.39 KB, patch)
2021-05-17 16:18 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-05-17 16:12:43 PDT 
Adopt SecTrustGetCertificateAtIndex replacement where available
Comment 1 Alex Christensen 2021-05-17 16:18:57 PDT 
Created attachment 428886 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-05-24 16:13:21 PDT 
<rdar://problem/78424044>
Comment 3 Chris Dumez 2021-06-07 18:38:44 PDT 
Comment on attachment 428886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428886&action=review

> Source/WebCore/platform/network/cocoa/CertificateInfoCocoa.mm:45
> +            RetainPtr<CFStringRef> summary = adoptCF(SecCertificateCopySubjectSummary(checked_cf_cast<SecCertificateRef>(CFArrayGetValueAtIndex(chain.get(), i))));

Could use auto
Comment 4 EWS 2021-06-07 19:25:56 PDT 
Committed r278590 (238580@main): <https://commits.webkit.org/238580@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428886 [details].