Bug 22589 - Cleaned up SegmentedVector by abstracting segment access into helper functions
Summary: Cleaned up SegmentedVector by abstracting segment access into helper functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-01 22:11 PST by Geoffrey Garen
Modified: 2008-12-02 16:17 PST (History)
0 users

See Also:

Attachments
patch (7.25 KB, patch)
2008-12-01 22:12 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2008-12-01 22:11:59 PST 
Patch coming.
Comment 1 Geoffrey Garen 2008-12-01 22:12:17 PST 
Created attachment 25663 [details]
patch

Haven't run SunSpider yet.
Comment 2 Sam Weinig 2008-12-02 05:52:03 PST 
Comment on attachment 25663 [details]
patch

r=me.  Very nice cleanup!
Comment 3 Geoffrey Garen 2008-12-02 13:31:31 PST 
Blergh. Crashes on SunSpider in release builds only. Here's a reduction:

(function () {
    for ( ; false; ) {
        for ( ; false; ) {
        }
        continue;
    }
})();
Comment 4 Geoffrey Garen 2008-12-02 13:32:16 PST 
Crashes beneath BytecodeGenerator::continueTarget when calling SegmentedVector::removeLast.
Comment 5 Geoffrey Garen 2008-12-02 16:13:25 PST 
Turns out the crash was due to out-of-date object files. Clean build fixed it.
Comment 6 Geoffrey Garen 2008-12-02 16:17:27 PST 
Committed revision 38925.