Our `git log` mocks do not support branches, which has some major downsides when developing additional git tooling.
<rdar://problem/78122705>
Created attachment 428873 [details] Patch
Created attachment 428891 [details] Patch
Created attachment 428894 [details] Patch
Created attachment 429084 [details] Patch
Created attachment 430883 [details] Patch
LGTM; unofficial r+.
Created attachment 431568 [details] Patch
Comment on attachment 431568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431568&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:532 > + if commit.hash.startswith(end) or end == branch: is it ever passible that the first commit will be in the middle of the range? This code would treat it as out of range
Comment on attachment 431568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431568&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:532 >> + if commit.hash.startswith(end) or end == branch: > > is it ever passible that the first commit will be in the middle of the range? This code would treat it as out of range Not if tests are well constructed. This change is entirely in unit testing code, so if begin is older than end, this function shouldn't return anything.
Created attachment 431612 [details] Patch for landing
Committed r278963 (238890@main): <https://commits.webkit.org/238890@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431612 [details].