Bug 225887 - Clean up code distinguishing between webgl/webgl2 contexts
Summary: Clean up code distinguishing between webgl/webgl2 contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on: 222758
Blocks:
  Show dependency tree / graph
 
Reported: 2021-05-17 14:26 PDT by Kenneth Russell
Modified: 2021-05-18 10:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2021-05-17 14:29 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2021-05-18 09:33 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2021-05-17 14:26:50 PDT 
Per review on Bug 222758 - the code recently added to properly distinguish between WebGL 1.0 and 2.0 contexts should be cleaned up.
Comment 1 Kenneth Russell 2021-05-17 14:29:31 PDT 
Created attachment 428870 [details]
Patch
Comment 2 Kenneth Russell 2021-05-17 20:23:52 PDT 
FYI, the test failures/flakes are not related to this patch.
Comment 3 Darin Adler 2021-05-17 23:05:36 PDT 
Comment on attachment 428870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428870&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:263
> +            if ((version == WebGLVersion::WebGL1) != (m_context->isWebGL1()))

Extra set of parentheses here that you did not add below.
Comment 4 Kenneth Russell 2021-05-18 09:33:47 PDT 
Created attachment 428948 [details]
Patch
Comment 5 Kenneth Russell 2021-05-18 09:34:09 PDT 
Thanks for your review Darin. Fixed, CQ'ing.
Comment 6 EWS 2021-05-18 10:32:30 PDT 
Committed r277659 (237864@main): <https://commits.webkit.org/237864@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428948 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-18 10:33:20 PDT 
<rdar://problem/78162049>