Bug 225885 - Drop unnecessary SQLiteDatabase::updateLastChangesCount()
Summary: Drop unnecessary SQLiteDatabase::updateLastChangesCount()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-17 14:04 PDT by Chris Dumez
Modified: 2021-05-17 17:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.22 KB, patch)
2021-05-17 14:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-17 14:04:47 PDT 
Drop unnecessary SQLiteDatabase::updateLastChangesCount().
Comment 1 Chris Dumez 2021-05-17 14:10:52 PDT 
Created attachment 428868 [details]
Patch
Comment 2 Alex Christensen 2021-05-17 16:25:16 PDT 
Comment on attachment 428868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428868&action=review

> Source/WebCore/ChangeLog:10
> +        + sqlite3_total_changes() in https://commits.webkit.org/r130891 to address an issue in WebSQL

I wonder how this "Christophe Dumez" feels about us undoing his hard work.
Comment 3 Chris Dumez 2021-05-17 16:26:15 PDT 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 428868 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428868&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        + sqlite3_total_changes() in https://commits.webkit.org/r130891 to address an issue in WebSQL
> 
> I wonder how this "Christophe Dumez" feels about us undoing his hard work.

muhahah, I was so surprised when I saw I did this. It was so long ago.
Comment 4 EWS 2021-05-17 17:11:47 PDT 
Committed r277618 (237833@main): <https://commits.webkit.org/237833@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428868 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-17 17:12:26 PDT 
<rdar://problem/78129682>