Bug 225884 - [iOS] Stop soft linking UIKit function in WebCore
Summary: [iOS] Stop soft linking UIKit function in WebCore
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-17 13:58 PDT by Per Arne Vollan
Modified: 2024-03-29 08:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2021-05-17 13:59 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2021-05-17 14:38 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2021-05-17 15:33 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2021-05-17 15:46 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.87 KB, patch)
2021-05-18 07:34 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.05 KB, patch)
2021-05-18 07:49 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (6.30 KB, patch)
2021-05-18 11:05 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (7.00 KB, patch)
2021-05-18 12:05 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (7.13 KB, patch)
2021-05-19 07:21 PDT, Per Arne Vollan 		thorton: review-
Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-05-17 13:58:22 PDT 
For performance reasons, stop soft linking UIAccessibilityIsInvertColorsEnabled.
Comment 1 Per Arne Vollan 2021-05-17 13:59:49 PDT 
Created attachment 428864 [details]
Patch
Comment 2 Per Arne Vollan 2021-05-17 14:38:04 PDT 
Created attachment 428874 [details]
Patch
Comment 3 Per Arne Vollan 2021-05-17 15:33:08 PDT 
Created attachment 428879 [details]
Patch
Comment 4 Per Arne Vollan 2021-05-17 15:46:17 PDT 
Created attachment 428881 [details]
Patch
Comment 5 Per Arne Vollan 2021-05-18 07:34:11 PDT 
Created attachment 428934 [details]
Patch
Comment 6 Per Arne Vollan 2021-05-18 07:49:28 PDT 
Created attachment 428937 [details]
Patch
Comment 7 Per Arne Vollan 2021-05-18 11:05:43 PDT 
Created attachment 428955 [details]
Patch
Comment 8 Per Arne Vollan 2021-05-18 12:05:08 PDT 
Created attachment 428961 [details]
Patch
Comment 9 Per Arne Vollan 2021-05-19 07:21:46 PDT 
Created attachment 429047 [details]
Patch
Comment 10 Radar WebKit Bug Importer 2021-05-19 07:22:42 PDT 
<rdar://problem/78204423>
Comment 11 Per Arne Vollan 2021-05-19 07:26:54 PDT 
<rdar://76012088>
Comment 12 Tim Horton 2021-05-19 09:57:45 PDT 
WebCore cannot link UIKit.
Comment 13 Tim Horton 2021-05-19 10:10:27 PDT 
(The correct layering would see you delegate this to WebKit and implement it there, but WebKitLegacy can’t link UIKit either so you’d have to further delegate out to UIKit in the WebKitLegacy case.)
Comment 14 Per Arne Vollan 2021-05-19 10:35:43 PDT 
(In reply to Tim Horton from comment #13)
> (The correct layering would see you delegate this to WebKit and implement it
> there, but WebKitLegacy can’t link UIKit either so you’d have to further
> delegate out to UIKit in the WebKitLegacy case.)

Ah, got it!

Thanks for reviewing!
Comment 15 David Kilzer (:ddkilzer) 2024-03-29 08:41:10 PDT 
I think we have to use upward linking to solve this, but we have to do it for all UIKit symbols used in WebCore.