Bug 225856 - Fix compilation with vanilla clang 7.1.0
Summary: Fix compilation with vanilla clang 7.1.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-16 11:30 PDT by Dmitry Kalinkin
Modified: 2021-06-24 11:49 PDT (History)
3 users (show)

See Also:


Attachments
1/1 (1.49 KB, patch)
2021-05-16 11:32 PDT, Dmitry Kalinkin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Kalinkin 2021-05-16 11:30:51 PDT
webkitgtk> ../Source/WebCore/platform/graphics/ColorComponents.h:110:33: error: call to 'abs' is ambiguous
webkitgtk>     return map([](T c) { return std::abs(c); });
webkitgtk>                                 ^~~~~~~~
webkitgtk> ../Source/WebCore/platform/graphics/filters/FETurbulence.cpp:344:88: note: in instantiation of member function 'WebCore::ColorComponents<float>::abs' requested here
webkitgtk>             turbulenceFunctionResult += noise2D(paintingData, stitchData, noiseVector).abs() / ratio;
webkitgtk>                                                                                        ^
webkitgtk> /nix/store/wd30p2pq4lci8fk9fqldkgk1hgmwpapj-Libsystem-1238.60.2/include/stdlib.h:129:6: note: candidate function
webkitgtk> int      abs(int) __pure2;
webkitgtk>          ^
webkitgtk> /nix/store/3ndhndpas5zaxpa63gldf2xgcd2skd3y-libc++-7.1.0/include/c++/v1/stdlib.h:111:44: note: candidate function
webkitgtk> inline _LIBCPP_INLINE_VISIBILITY long      abs(     long __x) _NOEXCEPT {return  labs(__x);}
webkitgtk>                                            ^
webkitgtk> /nix/store/3ndhndpas5zaxpa63gldf2xgcd2skd3y-libc++-7.1.0/include/c++/v1/stdlib.h:113:44: note: candidate function
webkitgtk> inline _LIBCPP_INLINE_VISIBILITY long long abs(long long __x) _NOEXCEPT {return llabs(__x);}
webkitgtk>                                            ^
webkitgtk> 3 warnings and 1 error generated.
Comment 1 Dmitry Kalinkin 2021-05-16 11:32:35 PDT
Created attachment 428797 [details]
1/1
Comment 2 Radar WebKit Bug Importer 2021-05-23 11:31:18 PDT
<rdar://problem/78370467>
Comment 3 EWS 2021-06-24 11:49:22 PDT
Committed r279240 (239125@main): <https://commits.webkit.org/239125@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428797 [details].