Bug 225845 - Allow conditionally enabling OffscreenCanvas only for non-worker contexts
Summary: Allow conditionally enabling OffscreenCanvas only for non-worker contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-15 14:00 PDT by Sam Weinig
Modified: 2021-05-17 09:14 PDT (History)
19 users (show)

See Also:

Attachments
Patch (38.41 KB, patch)
2021-05-15 14:12 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (87.08 KB, patch)
2021-05-15 16:58 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (38.39 KB, patch)
2021-05-15 19:11 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-05-15 14:00:32 PDT 
Split worker enablement out of OFFSCREEN_CANVAS using a new OFFSCREEN_CANVAS_IN_WORKER macro
Comment 1 Sam Weinig 2021-05-15 14:12:33 PDT 
Created attachment 428741 [details]
Patch
Comment 2 Darin Adler 2021-05-15 15:18:25 PDT 
Comment on attachment 428741 [details]
Patch

Looks OK.

I assume this is because some platform, perhaps Apple ones, may want to ship OffsceenCanvas outside of Workers sooner, because the issues in workers may take longer to resolve thoroughly.
Comment 3 Sam Weinig 2021-05-15 16:43:14 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 428741 [details]
> Patch
> 
> Looks OK.
> 
> I assume this is because some platform, perhaps Apple ones, may want to ship
> OffsceenCanvas outside of Workers sooner, because the issues in workers may
> take longer to resolve thoroughly.

Exactly.
Comment 4 Sam Weinig 2021-05-15 16:58:14 PDT 
Created attachment 428750 [details]
Patch
Comment 5 Sam Weinig 2021-05-15 19:11:49 PDT 
Created attachment 428763 [details]
Patch
Comment 6 EWS 2021-05-15 20:15:05 PDT 
Committed r277560 (237788@main): <https://commits.webkit.org/237788@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428763 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-15 20:16:16 PDT 
<rdar://problem/78068305>
Comment 8 Zan Dobersek 2021-05-17 00:19:21 PDT 
The ConditionalForWorker attribute values had unfortunate typos that ended up effectively disabling these interfaces under workers. Fixed in #225858.
Comment 9 Sam Weinig 2021-05-17 09:14:48 PDT 
(In reply to Zan Dobersek from comment #8)
> The ConditionalForWorker attribute values had unfortunate typos that ended
> up effectively disabling these interfaces under workers. Fixed in #225858.

Sorry about that :(. Thanks for the fix.