Bug 225843 - Clean up BaseAudioContext now that legacy/prefixed WebAudio is gone
Summary: Clean up BaseAudioContext now that legacy/prefixed WebAudio is gone
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 180332 (view as bug list)
Depends on: 225832
Blocks:
  Show dependency tree / graph
 
Reported: 2021-05-15 13:14 PDT by Chris Dumez
Modified: 2021-05-15 19:38 PDT (History)
15 users (show)

See Also:

Attachments
Patch (73.80 KB, patch)
2021-05-15 14:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-15 13:14:26 PDT 
Clean up BaseAudioContext now that legacy/prefixed WebAudio is gone. Now that we have a simpler class hierarchy, we can move more code out of BaseAudioContext and into its subclasses (OfflineAudioContext & AudioContext).
Comment 1 Chris Dumez 2021-05-15 14:57:07 PDT 
Created attachment 428744 [details]
Patch
Comment 2 Chris Dumez 2021-05-15 17:37:40 PDT 
*** Bug 180332 has been marked as a duplicate of this bug. ***
Comment 3 EWS 2021-05-15 18:05:27 PDT 
Committed r277553 (237781@main): <https://commits.webkit.org/237781@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428744 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-15 18:06:16 PDT 
<rdar://problem/78066681>