Bug 225831 - Turn callGetter() / callSetter() into instance methods
Summary: Turn callGetter() / callSetter() into instance methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-14 15:36 PDT by Alexey Shvayka
Modified: 2021-05-15 10:01 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.50 KB, patch)
2021-05-14 15:44 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (12.50 KB, patch)
2021-05-15 05:41 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-05-14 15:36:38 PDT 
Turn callGetter() / callSetter() into instance methods
Comment 1 Alexey Shvayka 2021-05-14 15:44:35 PDT 
Created attachment 428676 [details]
Patch
Comment 2 Alexey Shvayka 2021-05-14 15:45:31 PDT 
(In reply to Alexey Shvayka from comment #1)
> Created attachment 428676 [details]
> Patch

Consistent progression (> 10 runs) @ --outer 200:

                                   r277503                   patch

put-slow-no-cache-setter       49.5560+-0.4171     ^     48.4014+-0.3762        ^ definitely 1.0239x faster
Comment 3 Ross Kirsling 2021-05-14 15:54:54 PDT 
Comment on attachment 428676 [details]
Patch

r=me, patch looks straightforward and the little perf bump is nice.
Comment 4 Alexey Shvayka 2021-05-15 05:41:53 PDT 
Created attachment 428724 [details]
Patch

Move isValidCallee() to JSCell and handle primitives gracefully.
Comment 5 Alexey Shvayka 2021-05-15 05:44:05 PDT 
(In reply to Ross Kirsling from comment #3)
> Comment on attachment 428676 [details]
> Patch
> 
> r=me, patch looks straightforward and the little perf bump is nice.

Thank you for review!
Comment 6 EWS 2021-05-15 10:00:05 PDT 
Committed r277541 (237769@main): <https://commits.webkit.org/237769@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428724 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-15 10:01:19 PDT 
<rdar://problem/78059745>