Bug 225813 – Use PixelBufferFormat to specify ImageBuffer::getPixelBuffer destination format allowing for more control over data conversion

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Use PixelBufferFormat to specify ImageBuffer::getPixelData destination format allowing for more control over data conversion

[Sam Weinig]

Created attachment 428639 [details]
Patch

[Sam Weinig]

Created attachment 428642 [details]
Patch

[Sam Weinig]

Created attachment 428646 [details]
Patch

[Sam Weinig]

Created attachment 428647 [details]
Patch

[Darin Adler]

Comment on attachment 428647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428647&action=review

Nice improvement here.

> Source/WebCore/platform/graphics/ImageBufferBackend.cpp:181
> +    unsigned sourceBytesPerRow = 4 * sourcePixelBuffer.size().width();

auto?

> Source/WebCore/platform/graphics/ImageBufferBackend.cpp:182
> +    const uint8_t* sourceRows = sourcePixelBuffer.data().data() + sourceRectClipped.y() * sourceBytesPerRow + sourceRectClipped.x() * 4;

auto?

> Source/WebCore/platform/graphics/ImageBufferBackend.cpp:187
> +    PixelBufferFormat sourceFormat = sourcePixelBuffer.format();

auto?

[EWS]

Committed r277525 (237753@main): <https://commits.webkit.org/237753@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428647 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78040673>

[Sam Weinig]

(In reply to Darin Adler from comment #5)
> Comment on attachment 428647 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428647&action=review
> 
> Nice improvement here.
> 
> > Source/WebCore/platform/graphics/ImageBufferBackend.cpp:181
> > +    unsigned sourceBytesPerRow = 4 * sourcePixelBuffer.size().width();
> 
> auto?
> 
> > Source/WebCore/platform/graphics/ImageBufferBackend.cpp:182
> > +    const uint8_t* sourceRows = sourcePixelBuffer.data().data() + sourceRectClipped.y() * sourceBytesPerRow + sourceRectClipped.x() * 4;
> 
> auto?
> 
> > Source/WebCore/platform/graphics/ImageBufferBackend.cpp:187
> > +    PixelBufferFormat sourceFormat = sourcePixelBuffer.format();
> 
> auto?

I didn't ignore these by the way, they are fixed in a different way in my next change (https://bugs.webkit.org/show_bug.cgi?id=225841) and since that was already building, I figured I'd leave well enough alone on this one.