Bug 225798 - Rename FileSystem::getFileSize() to FileSystem::fileSize()
Summary: Rename FileSystem::getFileSize() to FileSystem::fileSize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-13 21:39 PDT by Chris Dumez
Modified: 2021-05-14 09:11 PDT (History)
27 users (show)

See Also:

Attachments
Patch (56.26 KB, patch)
2021-05-13 21:49 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (56.25 KB, patch)
2021-05-13 22:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-13 21:39:54 PDT 
Rename FileSystem::getFileSize() to FileSystem::fileSize(). Also have it return an Optional<uint64_t> instead of taking a long long out-parameter.
Comment 1 Chris Dumez 2021-05-13 21:49:50 PDT 
Created attachment 428601 [details]
Patch
Comment 2 Chris Dumez 2021-05-13 22:07:18 PDT 
Created attachment 428602 [details]
Patch
Comment 3 EWS 2021-05-14 09:10:46 PDT 
Committed r277492 (237726@main): <https://commits.webkit.org/237726@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428602 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-14 09:11:17 PDT 
<rdar://problem/78019212>