Bug 225782 - Work around WebCore failing to build due to NDEBUG getting undefined in release
Summary: Work around WebCore failing to build due to NDEBUG getting undefined in release
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on: 226709
Blocks:
  Show dependency treegraph
 
Reported: 2021-05-13 14:14 PDT by Tim Horton
Modified: 2021-06-06 23:45 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2021-05-13 14:14 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (4.10 KB, patch)
2021-05-13 15:18 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-05-13 14:14:08 PDT
Work around WebCore failing to build due to NDEBUG getting undefined in release
Comment 1 Tim Horton 2021-05-13 14:14:37 PDT
Created attachment 428560 [details]
Patch
Comment 2 Tim Horton 2021-05-13 14:14:39 PDT
<rdar://problem/77982432>
Comment 3 Alexey Proskuryakov 2021-05-13 14:16:44 PDT
Comment on attachment 428560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428560&action=review

> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:52
> +#if defined(WK_NDEBUG) && !defined(NDEBUG)

I'd undef WK_NDEBUG here, as leaking debug related defines from headers just doesn't feel good right now.
Comment 4 Tim Horton 2021-05-13 14:27:35 PDT
Fair point :)
Comment 5 Tim Horton 2021-05-13 15:18:58 PDT
Created attachment 428568 [details]
Patch
Comment 6 EWS 2021-05-13 16:27:28 PDT
Committed r277464 (237707@main): <https://commits.webkit.org/237707@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428568 [details].
Comment 7 WebKit Commit Bot 2021-06-06 23:30:06 PDT
Re-opened since this is blocked by bug 226709