Bug 225775 – [Cocoa] Plumb data detector results through some platform objects

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

Work towards rdar://75504956.

[Wenson Hsieh]

Created attachment 428570 [details]
Patch

[Wenson Hsieh]

Created attachment 428571 [details]
Fix non-internal builds

[Devin Rousso]

Comment on attachment 428570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428570&action=review

r=mews

> Source/WebCore/SourcesCocoa.txt:-240
> -platform/cocoa/DataDetectorsCoreSoftLink.mm @no-unify

Do you need to add this to another `SourcesCocoa.txt` and/or `.cmake` file in PAL?

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:3225
> +    return { WTFMove(result) };

NIT: I think you can drop the `{` `}`

[Wenson Hsieh]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 428570 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428570&action=review
> 
> r=mews
> 
> > Source/WebCore/SourcesCocoa.txt:-240
> > -platform/cocoa/DataDetectorsCoreSoftLink.mm @no-unify
> 
> Do you need to add this to another `SourcesCocoa.txt` and/or `.cmake` file
> in PAL?

PAL doesn't build with unified sources. However, there is a cmake file for PAL; I added the new headers there.

> 
> > Source/WebKit/Shared/WebCoreArgumentCoders.cpp:3225
> > +    return { WTFMove(result) };
> 
> NIT: I think you can drop the `{` `}`

👍🏻

[Wenson Hsieh]

Created attachment 428584 [details]
For EWS

[EWS]

Committed r277479 (237714@main): <https://commits.webkit.org/237714@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428584 [details].