Bug 225741 – Few webkitpy unit-tests fails in non-PST timezones

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

[Scripts]$./test-webkitpy
...
[1450/1990] webkitscmpy.test.svn_unittest.TestRemoteSvn.test_commits_branch failed:                                                       
  Traceback (most recent call last):
    File "OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 374, in test_commits_branch
      ]), Commit.Encoder().default(list(svn.commits(begin=dict(argument='r1'), end=dict(argument='r7')))))
  AssertionError: Lists differ: [{'re[47 chars]1601640900, 'order': 0, 'message': '7th commit[809 chars]nk'}] != [{'re[47 chars]1601651700, 'order': 0, 'message': '7th commit[809 chars]nk'}]
  
  First differing element 0:
  {'rev[46 chars]1601640900, 'order': 0, 'message': '7th commit[128 chars]h-a'}
  {'rev[46 chars]1601651700, 'order': 0, 'message': '7th commit[128 chars]h-a'}
  
  Diff is 1372 characters long. Set self.maxDiff to None to see it.
  
[1802/1990] webkitscmpy.test.svn_unittest.TestRemoteSvn.test_commits failed:
  Traceback (most recent call last):
    File "OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 364, in test_commits
      ]), Commit.Encoder().default(list(svn.commits(begin=dict(revision='r1'), end=dict(revision='r6')))))
  AssertionError: Lists differ: [{'re[44 chars]1601639900, 'order': 0, 'message': '6th commit[796 chars]nk'}] != [{'re[44 chars]1601650700, 'order': 0, 'message': '6th commit[796 chars]nk'}]
  
  First differing element 0:
  {'rev[43 chars]1601639900, 'order': 0, 'message': '6th commit[123 chars]unk'}
  {'rev[43 chars]1601650700, 'order': 0, 'message': '6th commit[123 chars]unk'}
  
    [{'author': {'emails': ['[e-mail]'], 'name': '[e-mail]'},
      'branch': 'trunk',
      'identifier': '4@trunk',
      'message': '6th commit',
      'order': 0,
      'repository_id': 'webkit',
      'revision': 6,
  -   'timestamp': 1601639900},
  ?                     ^^^
  
  +   'timestamp': 1601650700},
  ?                     ^^^
  
     {'author': {'emails': ['[e-mail]'], 'name': '[e-mail]'},
      'branch': 'trunk',
      'identifier': '3@trunk',
      'message': '4th commit',
      'order': 0,
      'repository_id': 'webkit',
      'revision': 4,
  -   'timestamp': 1601637900},
  ?                     ^ -
  
  +   'timestamp': 1601648700},
  ?                     ^^
  
     {'author': {'emails': ['[e-mail]'], 'name': '[e-mail]'},
      'branch': 'trunk',
      'identifier': '2@trunk',
      'message': '2nd commit',
      'order': 0,
      'repository_id': 'webkit',
      'revision': 2,
  -   'timestamp': 1601635900},
  ?                     ^^^
  
  +   'timestamp': 1601646700},
  ?                     ^^^
  
     {'author': {'emails': ['[e-mail]'], 'name': '[e-mail]'},
      'branch': 'trunk',
      'identifier': '1@trunk',
      'message': '1st commit',
      'order': 0,
      'repository_id': 'webkit',
      'revision': 1,
  -   'timestamp': 1601634900}]
  ?                     - ^
  
  +   'timestamp': 1601645700}]
  ?                      ^^
  
  
Mock process 68639 send signal 9
Mock process 68639 send signal 9
Mock process 68624 send signal 9
Mock process 68624 send signal 9
Ran 1990 tests in 6.933s                                                                                                                   
FAILED (failures=2, errors=0)


These tests pass when I set my timezone to PST.

[Jonathan Bedard]

Created attachment 428522 [details]
Patch

[EWS]

Committed r277440 (237688@main): <https://commits.webkit.org/237688@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428522 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77973121>