Bug 22574 - [GTK] Make webkit_web_view_set_window_features internal
Summary: [GTK] Make webkit_web_view_set_window_features internal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-12-01 14:53 PST by Holger Freyther
Modified: 2008-12-19 09:17 PST (History)
0 users

See Also:

Attachments
Make webkit_web_view_set_window_features internal (5.05 KB, patch)
2008-12-01 14:56 PST, Holger Freyther 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2008-12-01 14:53:07 PST 
Make webkit_web_view_set_window_features internal as it has the risk of missing a notify::window-features and there is no need to set that from the outside.
Comment 1 Holger Freyther 2008-12-01 14:56:37 PST 
Created attachment 25638 [details]
Make webkit_web_view_set_window_features internal

Make it internal, switch the user of this function over to use g_object_set.
Comment 2 Holger Freyther 2008-12-11 17:31:43 PST 
Landed in r39223.
Comment 3 Holger Freyther 2008-12-19 09:17:08 PST 
Comment on attachment 25638 [details]
Make webkit_web_view_set_window_features internal

Clear review, it was reviewed and landed.