Bug 225739 – Delete WebSQL code from WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Ryosuke Niwa]

We don't need WebSQL support in WebKit2 anymore. Delete the code.

[Ryosuke Niwa]

Created attachment 428478 [details]
Patch

[Sihui Liu]

Comment on attachment 428478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428478&action=review

> Source/WebKit/ChangeLog:17
> +        (WebKit::m_messagePortChannelRegistry): Deleted.

Deleted?

> Source/WebKit/ChangeLog:26
> +        * Shared/WebSQLiteDatabaseTracker.cpp: Removed.
> +        * Shared/WebSQLiteDatabaseTracker.h: Removed.

Despite its name, WebSQLiteDatabaseTracker is actually responsible for monitoring all SQLite operations (network process uses it to notify UI process to not suspend it during database operations, see SQLiteDatabaseTracker), so this seems wrong.

> Source/WebKit/ChangeLog:42
> +        (WebKit::m_lastNavigationWasAppBound):

I didn't see related change in this patch.

[Ryosuke Niwa]

(In reply to Sihui Liu from comment #2)
> Comment on attachment 428478 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428478&action=review
> 
> > Source/WebKit/ChangeLog:17
> > +        (WebKit::m_messagePortChannelRegistry): Deleted.
> 
> Deleted?
> 
> > Source/WebKit/ChangeLog:26
> > +        * Shared/WebSQLiteDatabaseTracker.cpp: Removed.
> > +        * Shared/WebSQLiteDatabaseTracker.h: Removed.
> 
> Despite its name, WebSQLiteDatabaseTracker is actually responsible for
> monitoring all SQLite operations (network process uses it to notify UI
> process to not suspend it during database operations, see
> SQLiteDatabaseTracker), so this seems wrong.

Oh, I see.

[Ryosuke Niwa]

Created attachment 428610 [details]
Patch

[Sam Weinig]

Comment on attachment 428610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428610&action=review

> Source/WTF/ChangeLog:3
> +        Delete WebSQL code from WebKit2

This seems to also be removing the WebKitLegacy code, is that intentional?

[Ryosuke Niwa]

(In reply to Sam Weinig from comment #5)
> Comment on attachment 428610 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428610&action=review
> 
> > Source/WTF/ChangeLog:3
> > +        Delete WebSQL code from WebKit2
> 
> This seems to also be removing the WebKitLegacy code, is that intentional?

Oh yeah, that was definitely not intentional. I was going to rename it and forgot to add the new one.

[Ryosuke Niwa]

Created attachment 428658 [details]
Patch

[Ryosuke Niwa]

Created attachment 428682 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 428682 [details]
Patch for landing

Wait for EWS.

[Ryosuke Niwa]

Created attachment 428720 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 428720 [details]
Patch for landing

Wait for EWS.

[EWS]

Committed r277564 (237792@main): <https://commits.webkit.org/237792@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428720 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78070560>