RESOLVED FIXED 225731
[LFC] Move geometry/quirk/margincollapse classes out of their FormattingContext 
https://bugs.webkit.org/show_bug.cgi?id=225731
Summary [LFC] Move geometry/quirk/margincollapse classes out of their FormattingContext
zalan
Reported 2021-05-12 20:50:56 PDT
This is about cleaning up the class interface and make them more readable.
Attachments
Patch (500.74 KB, patch)
2021-05-12 20:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (499.87 KB, patch)
2021-05-12 21:02 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-05-12 20:55:59 PDT
Created attachment 428454 [details] Patch
zalan
Comment 2 2021-05-12 21:02:26 PDT
Created attachment 428455 [details] Patch
zalan
Comment 3 2021-05-15 08:28:23 PDT
This is essentially a squashed version of the following patches: Move BlockMarginCollapse to its own class Move block formatting quirks to its own class Move table wrapper quirks to its own class Move inline formatting quirks to its own class Move table formatting quirks to its own class Move base formatting quirks to its own class Move block formatting geometry to its own class Move flex formatting geometry to its own class Move table formatting geometry to its own class Move base formatting geometry to its own class Make FormattingGeometry c'tors public Make redundant public helpers private in BlockFormattingContext Make redundant public helpers private in InlineFormattingContext Make redundant public helpers private in TableFormattingContext Make redundant public helpers private in FormattingContext Cleanup FormattingQuirk classes Cleanup MarginCollapsing class Cleanup FormattingContext class
Antti Koivisto
Comment 4 2021-05-15 08:33:37 PDT
Comment on attachment 428455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428455&action=review > Source/WebCore/ChangeLog:8 > + This is just an umbrella patch. nice umbrella
zalan
Comment 5 2021-05-16 09:02:45 PDT
All the patches have been landed. Closing now.
Note You need to log in before you can comment on or make changes to this bug.