Bug 225731 - [LFC] Move geometry/quirk/margincollapse classes out of their FormattingContext
Summary: [LFC] Move geometry/quirk/margincollapse classes out of their FormattingContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on: 225744 225745 225746 225747 225748 225749 225750 225751 225752 225753 225754 225755 225756 225757 225758 225759 225760 225761 225762
Blocks:
  Show dependency treegraph
 
Reported: 2021-05-12 20:50 PDT by zalan
Modified: 2021-05-16 09:03 PDT (History)
1 user (show)

See Also:


Attachments
Patch (500.74 KB, patch)
2021-05-12 20:55 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (499.87 KB, patch)
2021-05-12 21:02 PDT, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-05-12 20:50:56 PDT
This is about cleaning up the class interface and make them more readable.
Comment 1 zalan 2021-05-12 20:55:59 PDT
Created attachment 428454 [details]
Patch
Comment 2 zalan 2021-05-12 21:02:26 PDT
Created attachment 428455 [details]
Patch
Comment 3 zalan 2021-05-15 08:28:23 PDT
This is essentially a squashed version of the following patches:

Move BlockMarginCollapse to its own class
Move block formatting quirks to its own class
Move table wrapper quirks to its own class
Move inline formatting quirks to its own class
Move table formatting quirks to its own class
Move base formatting quirks to its own class
Move block formatting geometry to its own class
Move flex formatting geometry to its own class
Move table formatting geometry to its own class
Move base formatting geometry to its own class
Make FormattingGeometry c'tors public
Make redundant public helpers private in BlockFormattingContext
Make redundant public helpers private in InlineFormattingContext
Make redundant public helpers private in TableFormattingContext
Make redundant public helpers private in FormattingContext
Cleanup FormattingQuirk classes
Cleanup MarginCollapsing class
Cleanup FormattingContext class
Comment 4 Antti Koivisto 2021-05-15 08:33:37 PDT
Comment on attachment 428455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428455&action=review

> Source/WebCore/ChangeLog:8
> +        This is just an umbrella patch.

nice umbrella
Comment 5 zalan 2021-05-16 09:02:45 PDT
All the patches have been landed. Closing now.