NEW225724
Remove as much of WKPageGroupRef as possible 
https://bugs.webkit.org/show_bug.cgi?id=225724
Summary Remove as much of WKPageGroupRef as possible
Alex Christensen
Reported 2021-05-12 16:40:24 PDT
Remove as much of WKPageGroupRef as possible
Attachments
Patch (80.72 KB, patch)
2021-05-12 17:09 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (78.99 KB, patch)
2021-05-12 17:13 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (80.00 KB, patch)
2021-05-12 17:32 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (83.22 KB, patch)
2021-05-12 19:28 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (86.99 KB, patch)
2021-05-13 08:59 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (87.31 KB, patch)
2021-05-13 09:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (85.70 KB, patch)
2021-05-17 16:53 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (85.08 KB, patch)
2021-05-18 10:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (79.99 KB, patch)
2021-12-17 14:30 PST, Alex Christensen 		clopez: review-
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-05-12 17:09:34 PDT
Created attachment 428434 [details] Patch
Alex Christensen
Comment 2 2021-05-12 17:13:42 PDT
Created attachment 428435 [details] Patch
Alex Christensen
Comment 3 2021-05-12 17:32:37 PDT
Created attachment 428437 [details] Patch
Alex Christensen
Comment 4 2021-05-12 19:28:00 PDT
Created attachment 428448 [details] Patch
Alex Christensen
Comment 5 2021-05-13 08:59:24 PDT
Created attachment 428518 [details] Patch
Alex Christensen
Comment 6 2021-05-13 09:20:40 PDT
Created attachment 428521 [details] Patch
Alex Christensen
Comment 7 2021-05-17 16:53:08 PDT
Created attachment 428893 [details] Patch
Alex Christensen
Comment 8 2021-05-18 07:49:00 PDT
Comment on attachment 428893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428893&action=review > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:5594 > +void WebViewImpl::handleContextMenuTranslation(const WebCore::TranslationContextMenuInfo& info) Wenson already applied this change.
Alex Christensen
Comment 9 2021-05-18 10:25:29 PDT
Created attachment 428953 [details] Patch
Radar WebKit Bug Importer
Comment 10 2021-05-19 16:41:20 PDT
<rdar://problem/78231201>
Alex Christensen
Comment 11 2021-12-17 14:30:18 PST
Created attachment 447477 [details] Patch
Carlos Alberto Lopez Perez
Comment 12 2021-12-17 20:29:15 PST
Seems the GTK EWS has detected lot of crashes here. This EWS is kind of new here, it has been promoted to production just two days ago.ç However the failures it has detected (crashes) seem real. I can confirm. And sorry because (since this is still something kind of new) the detailed info about crash info is still not there. This is a known problem and I plan to fix it ASAP (hopefully next Monday). See bug 234272 If you find this useful, I have tried locally on GTK to run the "accessibility/" tests with this patch <https://bugs.webkit.org/attachment.cgi?id=447477> and I can confirm this patch introduces lot of new crashes (430 actually) just on those "accesibility/" tests. Those crashes were not happening before this patch. I have uploaded here the details of those crash logs: https://people.igalia.com/clopez/wkbug/225724/layout-test-results/results.html And sorry for this manual intervention. Ideally the EWS bot itself should report the crash logs. We plan to have the crash log reports automated ASAP so we don't need to do any manual steps to get those logs.
Note You need to log in before you can comment on or make changes to this bug.