Remove as much of WKPageGroupRef as possible
Created attachment 428434 [details]
Created attachment 428435 [details]
Created attachment 428437 [details]
Created attachment 428448 [details]
Created attachment 428518 [details]
Created attachment 428521 [details]
Created attachment 428893 [details]
Comment on attachment 428893 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=428893&action=review
> +void WebViewImpl::handleContextMenuTranslation(const WebCore::TranslationContextMenuInfo& info)
Wenson already applied this change.
Created attachment 428953 [details]
Created attachment 447477 [details]
Seems the GTK EWS has detected lot of crashes here. This EWS is kind of new here, it has been promoted to production just two days ago.ç
However the failures it has detected (crashes) seem real. I can confirm.
And sorry because (since this is still something kind of new) the detailed info about crash info is still not there. This is a known problem and I plan to fix it ASAP (hopefully next Monday). See bug 234272
If you find this useful, I have tried locally on GTK to run the "accessibility/" tests with this patch <https://bugs.webkit.org/attachment.cgi?id=447477> and I can confirm this patch introduces lot of new crashes (430 actually) just on those "accesibility/" tests. Those crashes were not happening before this patch.
I have uploaded here the details of those crash logs: https://people.igalia.com/clopez/wkbug/225724/layout-test-results/results.html
And sorry for this manual intervention. Ideally the EWS bot itself should report the crash logs. We plan to have the crash log reports automated ASAP so we don't need to do any manual steps to get those logs.