Bug 22572 – AccessibleBase.cpp should null-check the results of documentFrameView() calls

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

AccessibleBase.cpp should null-check the results of documentFrameView() calls

        Calling accLocation() when documentFrameView() could return NULL was the
        cause of the current #1 crasher in Chromium renderer processes.
        I don't expect this crash may even be possible in Win Safari.  But given
        that documentFrameView() clearly can return null (see implementation)
        it makes sense IMO to add these preventative checks.
        In our tree we've fixed the crash by checking mainFrame()->frameView()
        before ever calling this AX code.

It's possible this code is causing crashes for win safari like it was for Chrome, I don't have access to any win safari crash logs to confirm or deny.

[Eric Seidel (no email)]

Created attachment 25636 [details]
Add preventative NULL-check to AX calls

 WebKit/win/AccessibleBase.cpp |    7 +++++--
 WebKit/win/ChangeLog          |   19 +++++++++++++++++++
 2 files changed, 24 insertions(+), 2 deletions(-)

[Eric Seidel (no email)]

Adam Roben reviewed over irc.  Landing...

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/win/AccessibleBase.cpp
	M	WebKit/win/ChangeLog
Committed r38873