Bug 22572 - AccessibleBase.cpp should null-check the results of documentFrameView() calls
: AccessibleBase.cpp should null-check the results of documentFrameView() calls
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-12-01 14:05 PST by
Modified: 2008-12-01 14:11 PST (History)


Attachments
Add preventative NULL-check to AX calls (2.25 KB, patch)
2008-12-01 14:06 PST, Eric Seidel
aroben: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-12-01 14:05:24 PST
AccessibleBase.cpp should null-check the results of documentFrameView() calls

        Calling accLocation() when documentFrameView() could return NULL was the
        cause of the current #1 crasher in Chromium renderer processes.
        I don't expect this crash may even be possible in Win Safari.  But given
        that documentFrameView() clearly can return null (see implementation)
        it makes sense IMO to add these preventative checks.
        In our tree we've fixed the crash by checking mainFrame()->frameView()
        before ever calling this AX code.

It's possible this code is causing crashes for win safari like it was for Chrome, I don't have access to any win safari crash logs to confirm or deny.
------- Comment #1 From 2008-12-01 14:06:21 PST -------
Created an attachment (id=25636) [details]
Add preventative NULL-check to AX calls

 WebKit/win/AccessibleBase.cpp |    7 +++++--
 WebKit/win/ChangeLog          |   19 +++++++++++++++++++
 2 files changed, 24 insertions(+), 2 deletions(-)
------- Comment #2 From 2008-12-01 14:06:35 PST -------
Adam Roben reviewed over irc.  Landing...
------- Comment #3 From 2008-12-01 14:11:02 PST -------
Committing to http://svn.webkit.org/repository/webkit/trunk ...
    M    WebKit/win/AccessibleBase.cpp
    M    WebKit/win/ChangeLog
Committed r38873