Bug 225711 - Simplify / Modernize Notification permission implementation
Summary: Simplify / Modernize Notification permission implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 225712
  Show dependency treegraph
 
Reported: 2021-05-12 12:06 PDT by Chris Dumez
Modified: 2021-05-12 17:32 PDT (History)
9 users (show)

See Also:


Attachments
Patch (28.56 KB, patch)
2021-05-12 12:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (29.47 KB, patch)
2021-05-12 12:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (33.46 KB, patch)
2021-05-12 13:11 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (33.73 KB, patch)
2021-05-12 13:18 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (33.97 KB, patch)
2021-05-12 13:30 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-12 12:06:03 PDT
Simplify / Modernize Notification permission implementation.
Comment 1 Chris Dumez 2021-05-12 12:10:17 PDT
Created attachment 428400 [details]
Patch
Comment 2 EWS Watchlist 2021-05-12 12:11:10 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Chris Dumez 2021-05-12 12:50:27 PDT
Created attachment 428403 [details]
Patch
Comment 4 Alex Christensen 2021-05-12 12:51:56 PDT
Comment on attachment 428403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428403&action=review

> Source/WebKit/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:38
> +void NotificationPermissionRequestManagerProxy::invalidateRequests()

Now that we're using sendWithAsyncReply, I think we might not need this any more.  We might be able to completely remove the NotificationPermissionRequestManagerProxy.
Comment 5 Chris Dumez 2021-05-12 12:52:40 PDT
(In reply to Alex Christensen from comment #4)
> Comment on attachment 428403 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428403&action=review
> 
> > Source/WebKit/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:38
> > +void NotificationPermissionRequestManagerProxy::invalidateRequests()
> 
> Now that we're using sendWithAsyncReply, I think we might not need this any
> more.  We might be able to completely remove the
> NotificationPermissionRequestManagerProxy.

Oh. I may be even to drop more code then. Let me check :D
Comment 6 Chris Dumez 2021-05-12 13:11:29 PDT
Created attachment 428407 [details]
Patch
Comment 7 Chris Dumez 2021-05-12 13:18:21 PDT
Created attachment 428409 [details]
Patch
Comment 8 Chris Dumez 2021-05-12 13:30:54 PDT
Created attachment 428410 [details]
Patch
Comment 9 EWS 2021-05-12 17:31:49 PDT
Committed r277414 (237664@main): <https://commits.webkit.org/237664@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428410 [details].
Comment 10 Radar WebKit Bug Importer 2021-05-12 17:32:19 PDT
<rdar://problem/77941877>