Simplify / Modernize Notification permission implementation.
Created attachment 428400 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Created attachment 428403 [details] Patch
Comment on attachment 428403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428403&action=review > Source/WebKit/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:38 > +void NotificationPermissionRequestManagerProxy::invalidateRequests() Now that we're using sendWithAsyncReply, I think we might not need this any more. We might be able to completely remove the NotificationPermissionRequestManagerProxy.
(In reply to Alex Christensen from comment #4) > Comment on attachment 428403 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428403&action=review > > > Source/WebKit/UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:38 > > +void NotificationPermissionRequestManagerProxy::invalidateRequests() > > Now that we're using sendWithAsyncReply, I think we might not need this any > more. We might be able to completely remove the > NotificationPermissionRequestManagerProxy. Oh. I may be even to drop more code then. Let me check :D
Created attachment 428407 [details] Patch
Created attachment 428409 [details] Patch
Created attachment 428410 [details] Patch
Committed r277414 (237664@main): <https://commits.webkit.org/237664@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428410 [details].
<rdar://problem/77941877>