Bug 225709 - Plumb some more metadata to QuickLook when revealing images
Summary: Plumb some more metadata to QuickLook when revealing images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-12 11:58 PDT by Wenson Hsieh
Modified: 2021-05-12 14:08 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.73 KB, patch)
2021-05-12 12:19 PDT, Wenson Hsieh
drousso: review+
Details | Formatted Diff | Diff
Patch for landing (8.83 KB, patch)
2021-05-12 13:09 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-05-12 11:58:50 PDT
rdar://77864866
Comment 1 Wenson Hsieh 2021-05-12 12:19:46 PDT
Created attachment 428401 [details]
Patch
Comment 2 Devin Rousso 2021-05-12 12:31:52 PDT
Comment on attachment 428401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428401&action=review

r=me

> Source/WebKit/ChangeLog:26
> +        Rename the `URL` argument to `fileURL`, to avoid confusion with the new `imageURL` that's passed in. Note that
> +        this is temporary, since we'll adopt new QuickLook SPI on macOS once the fix for rdar://74299451 is available.

NIT: Should we put `FIXME` comments in the actual code for <rdar://74299451> so somebody else knows where to look if needed?
Comment 3 Wenson Hsieh 2021-05-12 12:44:12 PDT
Thanks for the review!

(In reply to Devin Rousso from comment #2)
> Comment on attachment 428401 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428401&action=review
> 
> r=me
> 
> > Source/WebKit/ChangeLog:26
> > +        Rename the `URL` argument to `fileURL`, to avoid confusion with the new `imageURL` that's passed in. Note that
> > +        this is temporary, since we'll adopt new QuickLook SPI on macOS once the fix for rdar://74299451 is available.
> 
> NIT: Should we put `FIXME` comments in the actual code for <rdar://74299451>
> so somebody else knows where to look if needed?

Makes sense — I'll add an inline FIXME referencing this radar in `WKImageExtractionPreviewController.mm`.
Comment 4 Wenson Hsieh 2021-05-12 13:09:21 PDT
Created attachment 428406 [details]
Patch for landing
Comment 5 EWS 2021-05-12 14:08:43 PDT
Committed r277389 (237645@main): <https://commits.webkit.org/237645@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428406 [details].