rdar://77864866
Created attachment 428401 [details] Patch
Comment on attachment 428401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428401&action=review r=me > Source/WebKit/ChangeLog:26 > + Rename the `URL` argument to `fileURL`, to avoid confusion with the new `imageURL` that's passed in. Note that > + this is temporary, since we'll adopt new QuickLook SPI on macOS once the fix for rdar://74299451 is available. NIT: Should we put `FIXME` comments in the actual code for <rdar://74299451> so somebody else knows where to look if needed?
Thanks for the review! (In reply to Devin Rousso from comment #2) > Comment on attachment 428401 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428401&action=review > > r=me > > > Source/WebKit/ChangeLog:26 > > + Rename the `URL` argument to `fileURL`, to avoid confusion with the new `imageURL` that's passed in. Note that > > + this is temporary, since we'll adopt new QuickLook SPI on macOS once the fix for rdar://74299451 is available. > > NIT: Should we put `FIXME` comments in the actual code for <rdar://74299451> > so somebody else knows where to look if needed? Makes sense — I'll add an inline FIXME referencing this radar in `WKImageExtractionPreviewController.mm`.
Created attachment 428406 [details] Patch for landing
Committed r277389 (237645@main): <https://commits.webkit.org/237645@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428406 [details].