Bug 225707 - Split pixel buffer format data out into a new PixelBufferFormat struct
Summary: Split pixel buffer format data out into a new PixelBufferFormat struct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-12 11:35 PDT by Sam Weinig
Modified: 2021-05-13 13:55 PDT (History)
13 users (show)

See Also:


Attachments
Patch (51.14 KB, patch)
2021-05-12 11:51 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (52.80 KB, patch)
2021-05-12 14:17 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (52.84 KB, patch)
2021-05-13 12:06 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (53.03 KB, patch)
2021-05-13 12:29 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-05-12 11:35:26 PDT
Split pixel buffer format data out into a new PixelBufferFormat struct
Comment 1 Sam Weinig 2021-05-12 11:51:51 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2021-05-12 12:42:21 PDT
Looks great, waiting to review until we have a version that’s a little more green on EWS.
Comment 3 Sam Weinig 2021-05-12 14:17:03 PDT
Created attachment 428419 [details]
Patch
Comment 4 Darin Adler 2021-05-12 15:46:19 PDT
Comment on attachment 428419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428419&action=review

> Source/WebCore/platform/graphics/PixelBufferFormat.cpp:35
> +    return ts << pixelBuffer.alphaFormat << " " << pixelBuffer.pixelFormat << " " << pixelBuffer.colorSpace;

Faster if you use ' ' instead of " "?

> Source/WebCore/platform/graphics/PixelBufferFormat.h:50
> +    encoder << alphaFormat;
> +    encoder << pixelFormat;
> +    encoder << colorSpace;

Use the one-line form?

> Source/WebCore/platform/graphics/PixelFormat.h:40
> +WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, PixelFormat);

Don’t need WTF prefix.
Comment 5 Sam Weinig 2021-05-13 12:06:18 PDT
Created attachment 428542 [details]
Patch
Comment 6 Sam Weinig 2021-05-13 12:29:30 PDT
Created attachment 428544 [details]
Patch
Comment 7 EWS 2021-05-13 13:54:29 PDT
Committed r277450 (237698@main): <https://commits.webkit.org/237698@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428544 [details].
Comment 8 Radar WebKit Bug Importer 2021-05-13 13:55:16 PDT
<rdar://problem/77985115>