Bug 225703 – [TestWebKitAPI] Explicitly exit after completing tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Our API tests run in a non-standard way. We can't rely on the system to exit the process cleanly or immediately after returning from main because iOS does not ordinarily support command line programs.

[Jonathan Bedard]

<rdar://problem/77673980>

[Jonathan Bedard]

Created attachment 428385 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 428385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428385&action=review

> Tools/TestWebKitAPI/ios/mainIOS.mm:56
> -    return passed ? EXIT_SUCCESS : EXIT_FAILURE;
> +    exit(passed ? EXIT_SUCCESS : EXIT_FAILURE);

If this works, it works, but please add a comment linking to a radar that tracks investigating the root cause here.

[Jonathan Bedard]

Created attachment 428397 [details]
Patch

[EWS]

Committed r277387 (237643@main): <https://commits.webkit.org/237643@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428397 [details].

[Darin Adler]

Comment on attachment 428397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428397&action=review

> Tools/TestWebKitAPI/ios/mainIOS.mm:56
> +    // FIXME: Work-around for <rdar://problem/77922262>

I understand that Alexey requested a comment. And a comment is good. However, we do not need a FIXME. We can use exit() forever and need never go back to using return here. The comment can help us remember not to change the code back!