RESOLVED FIXED 225699
Remove dead code around ENABLE(OPCODE_SAMPLING) and ENABLE(CODEBLOCK_SAMPLING). 
https://bugs.webkit.org/show_bug.cgi?id=225699
Summary Remove dead code around ENABLE(OPCODE_SAMPLING) and ENABLE(CODEBLOCK_SAMPLING).
Mark Lam
Reported 2021-05-12 07:51:41 PDT
This code revolves around an Interpreter::sampler() method which returns a SamplingTool*. Neither the Interpreter method nor the SamplingTool class exists anymore.
Attachments
proposed patch. (7.00 KB, patch)
2021-05-12 07:57 PDT, Mark Lam 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
proposed patch. (10.07 KB, patch)
2021-05-12 08:03 PDT, Mark Lam 		tzagallo: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-05-12 07:57:15 PDT
Created attachment 428374 [details] proposed patch.
Mark Lam
Comment 2 2021-05-12 08:03:37 PDT
Created attachment 428375 [details] proposed patch.
Tadeu Zagallo
Comment 3 2021-05-12 08:35:58 PDT
Comment on attachment 428375 [details] proposed patch. It looks like the ENABLE flags have already been removed from wtf, can you confirm?
Mark Lam
Comment 4 2021-05-12 08:43:38 PDT
(In reply to Tadeu Zagallo from comment #3) > Comment on attachment 428375 [details] > proposed patch. > > It looks like the ENABLE flags have already been removed from wtf, can you > confirm? The ENABLE flags don't exist.
Mark Lam
Comment 5 2021-05-12 08:49:12 PDT
Thanks for the review. Landed in r277370: <http://trac.webkit.org/r277370>.
Radar WebKit Bug Importer
Comment 6 2021-05-12 08:50:13 PDT
<rdar://problem/77910891>
Note You need to log in before you can comment on or make changes to this bug.