Bug 225699 - Remove dead code around ENABLE(OPCODE_SAMPLING) and ENABLE(CODEBLOCK_SAMPLING).
Summary: Remove dead code around ENABLE(OPCODE_SAMPLING) and ENABLE(CODEBLOCK_SAMPLING).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-12 07:51 PDT by Mark Lam
Modified: 2021-05-12 12:50 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (7.00 KB, patch)
2021-05-12 07:57 PDT, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
proposed patch. (10.07 KB, patch)
2021-05-12 08:03 PDT, Mark Lam 		tzagallo: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-05-12 07:51:41 PDT 
This code revolves around an Interpreter::sampler() method which returns a SamplingTool*.  Neither the Interpreter method nor the SamplingTool class exists anymore.
Comment 1 Mark Lam 2021-05-12 07:57:15 PDT 
Created attachment 428374 [details]
proposed patch.
Comment 2 Mark Lam 2021-05-12 08:03:37 PDT 
Created attachment 428375 [details]
proposed patch.
Comment 3 Tadeu Zagallo 2021-05-12 08:35:58 PDT 
Comment on attachment 428375 [details]
proposed patch.

It looks like the ENABLE flags have already been removed from wtf, can you confirm?
Comment 4 Mark Lam 2021-05-12 08:43:38 PDT 
(In reply to Tadeu Zagallo from comment #3)
> Comment on attachment 428375 [details]
> proposed patch.
> 
> It looks like the ENABLE flags have already been removed from wtf, can you
> confirm?

The ENABLE flags don't exist.
Comment 5 Mark Lam 2021-05-12 08:49:12 PDT 
Thanks for the review.  Landed in r277370: <http://trac.webkit.org/r277370>.
Comment 6 Radar WebKit Bug Importer 2021-05-12 08:50:13 PDT 
<rdar://problem/77910891>