Bug 225672 - [macCatalyst] should have CSS `hover: hover` and `pointer: fine`
Summary: [macCatalyst] should have CSS `hover: hover` and `pointer: fine`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-11 13:49 PDT by Devin Rousso
Modified: 2021-05-11 20:56 PDT (History)
14 users (show)

See Also:

Attachments
Patch (24.89 KB, patch)
2021-05-11 15:18 PDT, Devin Rousso 		thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (24.89 KB, patch)
2021-05-11 16:03 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (24.88 KB, patch)
2021-05-11 16:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-05-11 13:49:16 PDT 
macCatalyst should consider the mouse as the primary pointing device, just like macOS
Comment 1 Devin Rousso 2021-05-11 15:18:49 PDT 
Created attachment 428316 [details]
Patch
Comment 2 Tim Horton 2021-05-11 16:02:58 PDT 
Comment on attachment 428316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428316&action=review

> Source/WTF/wtf/PlatformHave.h:487
> +#define HAVE_MOUSE_DEVICE_OBSERVATION

need a `1` here

> Source/WTF/wtf/PlatformHave.h:798
> +#define HAVE_STYLUS_DEVICE_OBSERVATION

And here
Comment 3 Devin Rousso 2021-05-11 16:03:48 PDT 
Created attachment 428320 [details]
Patch
Comment 4 Devin Rousso 2021-05-11 16:05:02 PDT 
Created attachment 428322 [details]
Patch
Comment 5 EWS 2021-05-11 20:55:56 PDT 
Committed r277354 (237612@main): <https://commits.webkit.org/237612@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428322 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-11 20:56:15 PDT 
<rdar://problem/77878770>