Bug 225648 - Many canvas/media aspect-ratio failures
Summary: Many canvas/media aspect-ratio failures
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 217529
Blocks:
  Show dependency tree / graph
 
Reported: 2021-05-11 04:15 PDT by Anne van Kesteren
Modified: 2021-05-18 04:16 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2021-05-11 04:15:09 PDT 
In cleaning up some aspects of the specification around aspect-ratio, I found that WebKit fails a bunch of tests: https://github.com/web-platform-tests/wpt/pull/28932. Cleanup happening in https://github.com/whatwg/html/pull/6529.
Comment 1 Rob Buis 2021-05-11 11:55:45 PDT 
Cathie, IIRC you implemented this for one of video, image or canvas? We probably have existing bugs for these, which if fixed would fix these tests.
Comment 2 Rob Buis 2021-05-11 12:01:40 PDT 
I think bugs like this have to be fixed first:
https://bugs.webkit.org/show_bug.cgi?id=217529
Comment 3 Anne van Kesteren 2021-05-11 22:27:44 PDT 
Ah thanks for finding that Rob! that might be the whole issue here for all I know.
Comment 4 cathiechen 2021-05-12 01:59:53 PDT 
(In reply to Rob Buis from comment #1)
> Cathie, IIRC you implemented this for one of video, image or canvas? We
> probably have existing bugs for these, which if fixed would fix these tests.

Yeah, I'm working on implementing this for video and picture.
It seems most failures are `test_computed_style_aspect_ratio` which is related to bug 217529, i.e. implement mapping width height to aspect ratio by using CSS aspect-ratio.
Currently, the implementation in WebKit does not depend on CSS aspect-ratio.
Comment 5 Radar WebKit Bug Importer 2021-05-18 04:16:18 PDT 
<rdar://problem/78149269>