RESOLVED CONFIGURATION CHANGED 225642
Fix compile warning in non-CG platforms after r277232 
https://bugs.webkit.org/show_bug.cgi?id=225642
Summary Fix compile warning in non-CG platforms after r277232
Carlos Garcia Campos
Reported 2021-05-11 01:24:10 PDT
In file included from WebCore/PrivateHeaders/WebCore/Font.h:30, from WebCore/PrivateHeaders/WebCore/FontCascade.h:28, from WebCore/PrivateHeaders/WebCore/GraphicsContext.h:32, from WebCore/PrivateHeaders/WebCore/FrameView.h:31, from ../../Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:56: WebCore/PrivateHeaders/WebCore/GlyphBuffer.h: In member function ‘WTF::Optional<unsigned int> WebCore::GlyphBuffer::checkedStringOffsetAt(unsigned int, unsigned int) const’: WebCore/PrivateHeaders/WebCore/GlyphBuffer.h:81:20: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits] 81 | if (result < 0 || static_cast<unsigned>(result) >= stringLength) |
Attachments
Patch (1.39 KB, patch)
2021-05-11 01:25 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-05-11 01:25:35 PDT
Created attachment 428255 [details] Patch
EWS
Comment 2 2021-05-13 01:08:30 PDT
Tools/Scripts/svn-apply failed to apply attachment 428255 [details] to trunk. Please resolve the conflicts and upload a new patch.
Carlos Garcia Campos
Comment 3 2021-05-13 01:26:36 PDT
Darin fixed this in r277355
Note You need to log in before you can comment on or make changes to this bug.