Bug 225642 - Fix compile warning in non-CG platforms after r277232
Summary: Fix compile warning in non-CG platforms after r277232
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-11 01:24 PDT by Carlos Garcia Campos
Modified: 2021-05-13 01:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2021-05-11 01:25 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-05-11 01:24:10 PDT 
In file included from WebCore/PrivateHeaders/WebCore/Font.h:30,                                                                                                                                                    
                 from WebCore/PrivateHeaders/WebCore/FontCascade.h:28,                                                                                                                                             
                 from WebCore/PrivateHeaders/WebCore/GraphicsContext.h:32,                                                                                                                                         
                 from WebCore/PrivateHeaders/WebCore/FrameView.h:31,                                                                                                                                               
                 from ../../Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:56:                                                                                                                 
WebCore/PrivateHeaders/WebCore/GlyphBuffer.h: In member function ‘WTF::Optional<unsigned int> WebCore::GlyphBuffer::checkedStringOffsetAt(unsigned int, unsigned int) const’:                                      
WebCore/PrivateHeaders/WebCore/GlyphBuffer.h:81:20: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits]                                                                            
   81 |         if (result < 0 || static_cast<unsigned>(result) >= stringLength)                                                                                                                                   
      |
Comment 1 Carlos Garcia Campos 2021-05-11 01:25:35 PDT 
Created attachment 428255 [details]
Patch
Comment 2 EWS 2021-05-13 01:08:30 PDT 
Tools/Scripts/svn-apply failed to apply attachment 428255 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 3 Carlos Garcia Campos 2021-05-13 01:26:36 PDT 
Darin fixed this in r277355