Bug 225631 - [WebXR] Return a default layer handle in XRDeviceProxy::createLayerProjection
Summary: [WebXR] Return a default layer handle in XRDeviceProxy::createLayerProjection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-10 18:31 PDT by Ada Chan
Modified: 2021-05-11 07:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2021-05-10 18:32 PDT, Ada Chan 		dino: review+
Details | Formatted Diff | Diff
Patch for landing (4.97 KB, patch)
2021-05-10 18:56 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2021-05-10 18:31:12 PDT 
[WebXR] Return a default layer handle in XRDeviceProxy::createLayerProjection
Comment 1 Ada Chan 2021-05-10 18:32:42 PDT 
Created attachment 428233 [details]
Patch
Comment 2 Dean Jackson 2021-05-10 18:34:00 PDT 
Comment on attachment 428233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428233&action=review

> Source/WebKit/UIProcess/Cocoa/PlatformXRCoordinator.h:44
> +    static PlatformXR::LayerHandle defaultLayerHandle() { return 1; }

Maybe put a FIXME here saying it needs to be fixed.
Comment 3 Ada Chan 2021-05-10 18:56:39 PDT 
Created attachment 428236 [details]
Patch for landing
Comment 4 EWS 2021-05-11 07:56:01 PDT 
Committed r277324 (237583@main): <https://commits.webkit.org/237583@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428236 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-11 07:56:27 PDT 
<rdar://problem/77845149>