Bug 225626 - [Cocoa] Add _STAttributionDisplayName to macOS and iOS GPUProcess Info.plist
Summary: [Cocoa] Add _STAttributionDisplayName to macOS and iOS GPUProcess Info.plist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-10 17:25 PDT by Eric Carlson
Modified: 2021-05-11 10:14 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2021-05-10 17:37 PDT, Eric Carlson
youennf: review+
Details | Formatted Diff | Diff
Patch for landing (1.84 KB, patch)
2021-05-11 09:34 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2021-05-10 17:25:42 PDT
Add _STAttributionDisplayName to macOS GPUProcess Info.plist since capture can happen in the GPU process.
Comment 1 Eric Carlson 2021-05-10 17:26:39 PDT
rdar://77019240
Comment 2 Eric Carlson 2021-05-10 17:37:33 PDT
Created attachment 428230 [details]
Patch
Comment 3 youenn fablet 2021-05-11 06:02:02 PDT
Comment on attachment 428230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428230&action=review

> Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist:32
> +    <string>Website</string>

This does not seem in sync with the title.
Comment 4 Eric Carlson 2021-05-11 09:34:19 PDT
Created attachment 428283 [details]
Patch for landing
Comment 5 EWS 2021-05-11 10:14:25 PDT
Committed r277327 (237586@main): <https://commits.webkit.org/237586@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428283 [details].