We should attribute app-bound status to speculative revalidation requests.
<rdar://problem/77664358>
Created attachment 428206 [details] Patch
The test for this technically relies on infrastructure added in https://bugs.webkit.org/show_bug.cgi?id=225596 (in review) but since they are skipped for open source builds this won't affect EWS.
Comment on attachment 428206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428206&action=review > Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:96 > + revalidationRequest.setIsAppBound(subResourceInfo.isAppBound()); I suggest we bundle these various "copy request state to new request" into some common function somewhere (not for this patch though). > LayoutTests/platform/ios-wk2/TestExpectations:1794 > +http/tests/in-app-browser-privacy/app-bound-attribution-speculative-revalidation.html [ Skip ] Why do we need to skip on iOS? Is this because of missing test features, or does the test just not work on iOS?
Comment on attachment 428206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428206&action=review r=me >> LayoutTests/platform/ios-wk2/TestExpectations:1794 >> +http/tests/in-app-browser-privacy/app-bound-attribution-speculative-revalidation.html [ Skip ] > > Why do we need to skip on iOS? Is this because of missing test features, or does the test just not work on iOS? I spoke with Kate about this offline. It's skipped in iOS on Open Source. So this is fine (and will be unskilled in future).
Created attachment 428217 [details] Patch for landing
Committed r277306 (237567@main): <https://commits.webkit.org/237567@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428217 [details].