Bug 22561 - Enable WML Support for Windows
Summary: Enable WML Support for Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Enhancement
Assignee: Nobody
Depends on:
Reported: 2008-11-29 21:32 PST by Brent Fulgham
Modified: 2008-12-01 22:50 PST (History)
2 users (show)

See Also:

Add WML files to Windows Build (39.59 KB, patch)
2008-11-30 12:24 PST, Brent Fulgham
aroben: review-
Details | Formatted Diff | Diff
Add WML files to project (39.53 KB, patch)
2008-12-01 20:29 PST, Brent Fulgham
aroben: review+
Details | Formatted Diff | Diff
Regenerated VCPROJ against ToT to aid in landing (40.12 KB, patch)
2008-12-01 22:37 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-11-29 21:32:10 PST
This update enables support for WML pages in the Windows build of WebKit (both the standard CG and the Cairo variant).  This brings the Windows platform in line with the Mac and Gtk variants.
Comment 1 Brent Fulgham 2008-11-29 21:34:14 PST
Note that the Windows build already autogenerates the necessary WML support files from the *.in files, since the generic DerivedSources.make and related Perl scripts already do the heavy lifting.

Consequently, this update consists of two changes:
1.  Add the necessary WML files to the build.
2.  Extend the preprocessor macros to include ENABLE_WML.

Once this is done, some testing will be needed to confirm the new format is completely supported.
Comment 2 Brent Fulgham 2008-11-30 12:24:34 PST
Created attachment 25615 [details]
Add WML files to Windows Build

Note:  For these files to actually execute the ENABLE_WML tag must be added to two places:
1.  The Visual Studio preprocessor definitions in the MSVC project.
2.  The build-generated-files.sh script.
Comment 3 Adam Roben (:aroben) 2008-12-01 13:09:07 PST
Comment on attachment 25615 [details]
Add WML files to Windows Build

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 38852)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,11 @@
> +2008-11-30  Brent Fulgham  <bfulgham@gmail.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add WML related files to Visual Studio projects.
> +
> +        * WebCore.vcproj/WebCore.vcproj:

You should mention the other changes you made to the vcproj file in the ChangeLog, since the diffs are so hard to read.


WML support is disabled by default for all ports right now, so I don't think we should turn it on by default for Windows.

The added files/include paths look fine.
Comment 4 Brent Fulgham 2008-12-01 20:29:15 PST
Created attachment 25656 [details]
Add WML files to project

Revised patch with better comments about changes.  Please note that the Preprocessor Definition changes are purely from alphabetizing the list.  There are no additions or omissions.
Comment 5 Adam Roben (:aroben) 2008-12-01 20:31:13 PST
Comment on attachment 25656 [details]
Add WML files to project

Comment 6 Brent Fulgham 2008-12-01 22:37:54 PST
Created attachment 25666 [details]
Regenerated VCPROJ against ToT to aid in landing

Reviewed previously.  Diff regenerated to avoid conflicts during landing.
Comment 7 Matt Lilek 2008-12-01 22:50:15 PST
Committed revision 38897.