Bug 225600 - [macOS] Allow immediate action gestures to begin when force clicking text inside image overlays
Summary: [macOS] Allow immediate action gestures to begin when force clicking text ins...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-10 11:16 PDT by Wenson Hsieh
Modified: 2021-05-10 21:31 PDT (History)
15 users (show)

See Also:

Attachments
For EWS (24.48 KB, patch)
2021-05-10 16:49 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix non-internal macOS builds (25.86 KB, patch)
2021-05-10 17:08 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
For EWS (26.57 KB, patch)
2021-05-10 20:08 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-05-10 11:16:16 PDT 
.
Comment 1 Radar WebKit Bug Importer 2021-05-10 15:37:37 PDT 
<rdar://problem/77792365>
Comment 2 Wenson Hsieh 2021-05-10 16:49:22 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2021-05-10 17:08:23 PDT 
Created attachment 428223 [details]
Fix non-internal macOS builds
Comment 4 Wenson Hsieh 2021-05-10 19:25:18 PDT 
Comment on attachment 428223 [details]
Fix non-internal macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=428223&action=review

> Source/WebCore/rendering/HitTestRequest.h:51
> +        DisallowUserAgentShadowContentExceptForImageOverlays = 1 << 16,

Devin pointed out over Slack that this should go right after the existing option — I'll make this adjustment before landing.
Comment 5 Wenson Hsieh 2021-05-10 20:08:04 PDT 
Created attachment 428240 [details]
For EWS
Comment 6 EWS 2021-05-10 21:31:24 PDT 
Committed r277316 (237575@main): <https://commits.webkit.org/237575@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428240 [details].