RESOLVED FIXED Bug 225591
REGRESSION(r275515): wpt/quirks/blocks-ignore-line-height.html 
https://bugs.webkit.org/show_bug.cgi?id=225591
Summary REGRESSION(r275515): wpt/quirks/blocks-ignore-line-height.html
Sam Sneddon [:gsnedders]
Reported 2021-05-10 05:20:46 PDT
Via STP124 regressing this on wpt.fyi. Quick glance makes it look like LFC is applying the standards-mode behaviour in all modes.
Attachments
Test reduction (246 bytes, text/html)
2021-05-10 10:00 PDT, zalan 		no flags
Details
Patch (7.78 KB, patch)
2021-05-10 20:34 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (8.51 KB, patch)
2021-05-11 06:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-05-10 08:25:09 PDT
(In reply to Sam Sneddon [:gsnedders] from comment #0) > Via STP124 regressing this on wpt.fyi. > > Quick glance makes it look like LFC is applying the standards-mode behaviour > in all modes. Indeed, this looks like a standards vs. quirk mode confusion.
zalan
Comment 2 2021-05-10 10:00:32 PDT
Created attachment 428179 [details] Test reduction Actually this looks to be about resolving the "line-height: <number>" value in quirks mode when the root inline box is empty and the inline box (<span>) has different font-size value as the containing block.
Radar WebKit Bug Importer
Comment 3 2021-05-10 10:40:33 PDT
<rdar://problem/77766308>
zalan
Comment 4 2021-05-10 20:34:22 PDT
Created attachment 428242 [details] Patch
zalan
Comment 5 2021-05-11 06:55:27 PDT
Created attachment 428271 [details] Patch
EWS
Comment 6 2021-05-11 08:33:21 PDT
Committed r277325 (237584@main): <https://commits.webkit.org/237584@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428271 [details].
Note You need to log in before you can comment on or make changes to this bug.